From 53d64a595520ecec85ba3069f0df35f9ed9001a0 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Thu, 23 Jan 2025 20:01:37 +0100
Subject: [PATCH] unique_impl_ptr: fix bug in operator<

A non-const std::less instantiation cannot be used for const data.
---
 spimpl.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/spimpl.h b/spimpl.h
index 7dafccf..f929e60 100644
--- a/spimpl.h
+++ b/spimpl.h
@@ -268,8 +268,8 @@ namespace spimpl {
     template <class T1, class D1, class T2, class D2>
     inline bool operator< (const unique_impl_ptr<T1, D1>& l, const unique_impl_ptr<T2, D2>& r)
     {
-        using P1 = typename unique_impl_ptr<T1, D1>::pointer;
-        using P2 = typename unique_impl_ptr<T2, D2>::pointer;
+        using P1 = typename unique_impl_ptr<T1, D1>::const_pointer;
+        using P2 = typename unique_impl_ptr<T2, D2>::const_pointer;
         using CT = typename std::common_type<P1, P2>::type;
         return std::less<CT>()(l.get(), r.get());
     }
@@ -319,14 +319,14 @@ namespace spimpl {
     template <class T, class D>
     inline bool operator< (const unique_impl_ptr<T, D>& l, std::nullptr_t)
     {
-        using P = typename unique_impl_ptr<T, D>::pointer;
+        using P = typename unique_impl_ptr<T, D>::const_pointer;
         return std::less<P>()(l.get(), nullptr);
     }
 
     template <class T, class D>
     inline bool operator< (std::nullptr_t, const unique_impl_ptr<T, D>& p)
     {
-        using P = typename unique_impl_ptr<T, D>::pointer;
+        using P = typename unique_impl_ptr<T, D>::const_pointer;
         return std::less<P>()(nullptr, p.get());
     }