Skip to content

Commit 095fe12

Browse files
committed
Merge branch 'main' into feat/registry-improvements
2 parents 4550e53 + 9fc6121 commit 095fe12

1 file changed

Lines changed: 11 additions & 22 deletions

File tree

tests/provider/test_registry.py

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from unittest.mock import Mock
22

3+
import pytest
4+
35
from openfeature.exception import GeneralError
46
from openfeature.provider import ProviderStatus
57
from openfeature.provider._registry import ProviderRegistry
@@ -16,27 +18,19 @@ def test_registry_serves_noop_as_default():
1618
def test_setting_provider_requires_domain():
1719
registry = ProviderRegistry()
1820

19-
try:
21+
with pytest.raises(GeneralError) as exc_info:
2022
registry.set_provider(None, NoOpProvider()) # type: ignore[reportArgumentType]
21-
raise AssertionError(
22-
"Expected an exception when setting provider with None domain"
23-
)
24-
except GeneralError as e:
25-
assert e.error_message == "No domain"
26-
except Exception as e:
27-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
23+
24+
assert exc_info.value.error_message == "No domain"
2825

2926

3027
def test_setting_provider_requires_provider():
3128
registry = ProviderRegistry()
3229

33-
try:
30+
with pytest.raises(GeneralError) as exc_info:
3431
registry.set_provider("domain", None) # type: ignore[reportArgumentType]
35-
raise AssertionError("Expected an exception when setting provider to None")
36-
except GeneralError as e:
37-
assert e.error_message == "No provider"
38-
except Exception as e:
39-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
32+
33+
assert exc_info.value.error_message == "No provider"
4034

4135

4236
def test_can_register_provider_to_multiple_domains():
@@ -82,15 +76,10 @@ def test_registering_provider_for_first_time_initializes_it():
8276
def test_setting_default_provider_requires_provider():
8377
registry = ProviderRegistry()
8478

85-
try:
79+
with pytest.raises(GeneralError) as exc_info:
8680
registry.set_default_provider(None) # type: ignore[reportArgumentType]
87-
raise AssertionError(
88-
"Expected an exception when setting default provider to None"
89-
)
90-
except GeneralError as e:
91-
assert e.error_message == "No provider"
92-
except Exception as e:
93-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
81+
82+
assert exc_info.value.error_message == "No provider"
9483

9584

9685
def test_replacing_default_provider_shuts_down_old_one():

0 commit comments

Comments
 (0)