[DO NOT MERGE] Demonstrate uri resolve behavior change from java 11 to 17 #7969
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7969 +/- ##
=========================================
Coverage 90.14% 90.14%
Complexity 7476 7476
=========================================
Files 836 836
Lines 22554 22554
Branches 2224 2224
=========================================
Hits 20331 20331
Misses 1519 1519
Partials 704 704 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
😱 |
jack-berg
commented
Jan 9, 2026
| @Test | ||
| void resolve() { | ||
| assertThat(URI.create("http://localhost:8080").resolve("path").toString()) | ||
| .isEqualTo("http://localhost:8080/path"); |
Member
Author
There was a problem hiding this comment.
URI.resolve behavior change!
Passes on java 17+. Fails on java 11 and lower.
Contributor
There was a problem hiding this comment.
whu? That's a surprising change (that I imagine will break lots of applications out there!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.