From 9c75340c91010e752a273107a5f905410f47245e Mon Sep 17 00:00:00 2001 From: "Michael A. Smith" Date: Tue, 12 May 2026 12:46:45 -0400 Subject: [PATCH] chore: drop ghost phpunit and phpunit-coverage docker services MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These compose services referenced dockerfile: Dockerfile.test which has never existed in the repo — and the corresponding Taskfile entries (task test:docker, task test:coverage) have been broken since they were added. The functionality is covered elsewhere: - task test:unit runs unit tests locally (composer test:unit) - task test:integration / task test:e2e exec into the running openemr container (matches the pattern that already works) - CI handles coverage via the openCoreEMR/github-workflows-public php-tests reusable when opted in via coverage-php-version If local coverage HTML reports become a real need, add a Dockerfile.test and reintroduce the services. --- Taskfile.yml | 10 ---------- compose.yml | 26 -------------------------- 2 files changed, 36 deletions(-) diff --git a/Taskfile.yml b/Taskfile.yml index eaee98d..90c967a 100644 --- a/Taskfile.yml +++ b/Taskfile.yml @@ -298,16 +298,6 @@ tasks: - task: test:integration - task: test:e2e - test:coverage: - desc: Run PHPUnit with coverage report - cmds: - - docker compose run --rm phpunit-coverage - - test:docker: - desc: Run PHPUnit tests in Docker - cmds: - - docker compose run --rm phpunit - # === Development Helpers === composer:install: diff --git a/compose.yml b/compose.yml index 79ff3a3..cf7c85a 100644 --- a/compose.yml +++ b/compose.yml @@ -3,7 +3,6 @@ # Extends OpenEMR's development-easy services with overrides: # - Random ports bound to 127.0.0.1 (avoid conflicts; never expose dev DB to LAN) # - CLI tool mounted into OpenEMR container -# - PHPUnit services available via profiles name: oce-cli-import-codes @@ -69,31 +68,6 @@ services: file: vendor/openemr/openemr/docker/development-easy/docker-compose.yml service: phpmyadmin - # PHPUnit test runner - phpunit: - build: - context: . - dockerfile: Dockerfile.test - volumes: - - .:/app - - /app/vendor - command: vendor/bin/phpunit --testdox - profiles: [test] - - # PHPUnit with coverage - phpunit-coverage: - build: - context: . - dockerfile: Dockerfile.test - volumes: - - .:/app - - /app/vendor - - ./htmlcov:/app/htmlcov - environment: - XDEBUG_MODE: coverage - command: vendor/bin/phpunit --coverage-html htmlcov --coverage-text - profiles: [test] - volumes: databasevolume: {} assetvolume: {}