Favorite action on Shared folder leaks to Folder owner

[Jip-Hop]

Describe the bug

When an admin shares a folder with a user and grants "Can edit" rights, and this user marks this folder as favorite using the iOS app, then a star will appear in the web interface of the folder owner even though the folder owner did not mark this folder as favorite. When the user the folder has been shared with only has "Can view" rights, this user cannot modify the favorite status on this folder using the iOS app. It will result in:

Error updating shared_by_admin metadata
The operation couldn't be completed.
(OCHTTPStatusErrorDomain error 403.)

Dennis sees folder with a star

Yet Dennis has no favorites

Steps to reproduce

1. Create folder as dennis
2. Share with mary with "Can edit" rights
3. Connect as mary to demo.opencloud.eu with iOS app
4. Mark shared folder as favorite
5. As dennis see a star appear in web interface on this shared folder

Expected behavior

When a user marks a shared folder as favorite then this shouldn't be visible for the folder owner.

Actual behavior

The folder owner will see a star in the web interface for the shared folder, even though the owner never starred this folder.

Setup

Tested on demo.opencloud.eu (OpenCloud 6.1.0 rolling) with dennis and mary and the iOS app 1.0.1 (26 april).

Additional context

Add any other context about the problem here.

[AlexAndBear]

@aduffeck AFAIK this is happening due to using the old mechanism/api to favorite files, but you already have a pr to prevent this, right ?

Makes me wonder, who is responsible for adapting the iOS/android app.