Favorites feature broken on mobile clients after re-enabling capability flag

[AlexAndBear]

We recently re-enabled favorites in OpenCloud by setting the favorites capability flag back to true. This makes sense on the backend side now, since we finally have the new Graph API available for favoriting / unfavoriting files with proper persistence.

However, there is currently a mismatch in the clients:

• WebUI can use the new Graph API
• iOS / Android clients still only use the old WebDAV-based favorites flow

Since the favorites capability is now globally enabled again, mobile clients also expose the feature, but they are still using the outdated WebDAV flow.

Current Result

Favorites are now effectively diverged / broken:

• Users can favorite files in mobile apps
• Those favorites do not appear correctly on the Favorites page
• Different clients behave inconsistently
• Overall UX is confusing and feels broken

Proposal

Introduce two separate capability flags:

• favorites → set to false, so existing iOS / Android clients hide the old feature again
• favoritesV2 → true by default, used by WebUI for the new Graph API based implementation, as soon as clients follow the new workflow they can use this capabilty.
• disable setting favorite flag via WebDAV entirely, should fix: Favorite action on Shared folder leaks to Folder owner #2676

[tbsbdr]

thanks @AlexAndBear for the plan, lets go!

[tbsbdr]

asessing as P2 as favourites will be rollouled out with the prod release and should be available on the long run in the mobile clients as well.

[AlexAndBear]

Spoke with @aduffeck and @tbsbdr favorites should not be enabled or disabled via config.

So it makes more sense to not introduce favoritesV2 but set favorites to false. Web will not pay attention to this capability and clients will ignore it in the future as well, when the new mechanism is implemented. After that we can remove capability favorites entireley