diff --git a/teamengine-core/src/main/java/com/occamlab/te/CtlEarlReporter.java b/teamengine-core/src/main/java/com/occamlab/te/CtlEarlReporter.java index d9127487..acbd3de2 100644 --- a/teamengine-core/src/main/java/com/occamlab/te/CtlEarlReporter.java +++ b/teamengine-core/src/main/java/com/occamlab/te/CtlEarlReporter.java @@ -252,6 +252,11 @@ private void getSubtestResult(Model model, NodeList testcallList, NodeList logLi if (cFailCount > 0 || cInheritedFailureCount > 0) { areCoreConformanceClassesPassed = false; } + // prevent passing of basic conformance class with all tests skipped + // see https://github.com/opengeospatial/teamengine/issues/636 + else if (cFailCount == 0 && cInheritedFailureCount == 0 && cPassCount == 0 && cSkipCount > 0) { + areCoreConformanceClassesPassed = false; + } } this.totalPassCount += cPassCount; this.totalFailCount += cFailCount; diff --git a/teamengine-resources/src/main/resources/com/occamlab/te/earl_html_report.xsl b/teamengine-resources/src/main/resources/com/occamlab/te/earl_html_report.xsl index e40c6d41..542e7bc2 100644 --- a/teamengine-resources/src/main/resources/com/occamlab/te/earl_html_report.xsl +++ b/teamengine-resources/src/main/resources/com/occamlab/te/earl_html_report.xsl @@ -219,6 +219,9 @@ + + + diff --git a/teamengine-spi/src/main/java/com/occamlab/te/spi/executors/testng/EarlReporter.java b/teamengine-spi/src/main/java/com/occamlab/te/spi/executors/testng/EarlReporter.java index 1e696fa9..5e8b56b2 100644 --- a/teamengine-spi/src/main/java/com/occamlab/te/spi/executors/testng/EarlReporter.java +++ b/teamengine-spi/src/main/java/com/occamlab/te/spi/executors/testng/EarlReporter.java @@ -170,6 +170,11 @@ void processSuiteResults(Model model, Map results) { if (nFailed > 0) { areCoreConformanceClassesPassed = false; } + // prevent passing of basic conformance class with all tests skipped + // see https://github.com/opengeospatial/teamengine/issues/636 + else if (nFailed == 0 && nPassed == 0 && nSkipped > 0) { + areCoreConformanceClassesPassed = false; + } } processTestResults(model, testContext.getFailedTests()); processTestResults(model, testContext.getSkippedTests());