Better const-correctness on Linux

asomers · asomers · commit 970c0d66e656 · 2025-09-25T10:58:50.000-06:00
Signed-off-by: Alan Somers &lt;asomers@gmail.com&gt;
diff --git a/include/os/linux/spl/sys/rwlock.h b/include/os/linux/spl/sys/rwlock.h
@@ -63,8 +63,8 @@ spl_rw_clear_owner(krwlock_t *rwp)
 	rwp->rw_owner = NULL;
 }
 
-static inline kthread_t *
-rw_owner(krwlock_t *rwp)
+static inline const kthread_t *
+rw_owner(const krwlock_t *rwp)
 {
 	return (rwp->rw_owner);
 }
@@ -100,7 +100,7 @@ RW_LOCK_HELD(krwlock_t *rwp)
 }
 
 static inline int
-RW_WRITE_HELD(krwlock_t *rwp)
+RW_WRITE_HELD(const krwlock_t *rwp)
 {
 	return (rw_owner(rwp) == current);
 }

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,8 @@ spl_rw_clear_owner(krwlock_t *rwp)`
`63`	`63`	`rwp->rw_owner = NULL;`
`64`	`64`	`}`
`65`	`65`
`66`		`-static inline kthread_t *`
`67`		`-rw_owner(krwlock_t *rwp)`
	`66`	`+static inline const kthread_t *`
	`67`	`+rw_owner(const krwlock_t *rwp)`
`68`	`68`	`{`
`69`	`69`	`return (rwp->rw_owner);`
`70`	`70`	`}`
`@@ -100,7 +100,7 @@ RW_LOCK_HELD(krwlock_t *rwp)`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`static inline int`
`103`		`-RW_WRITE_HELD(krwlock_t *rwp)`
	`103`	`+RW_WRITE_HELD(const krwlock_t *rwp)`
`104`	`104`	`{`
`105`	`105`	`return (rw_owner(rwp) == current);`
`106`	`106`	`}`