From d78fc71ba118ac0deb2a409a8608341ef621f4c2 Mon Sep 17 00:00:00 2001 From: lynn Date: Mon, 4 May 2026 15:51:46 -0700 Subject: [PATCH 1/2] AO3-7398 Add username to Challenge Sign-Ups browser page title --- app/controllers/challenge_signups_controller.rb | 1 + config/locales/controllers/en.yml | 2 ++ spec/controllers/challenge_signups_controller_spec.rb | 8 ++++++++ 3 files changed, 11 insertions(+) diff --git a/app/controllers/challenge_signups_controller.rb b/app/controllers/challenge_signups_controller.rb index 16e5d264b6c..834c3522749 100644 --- a/app/controllers/challenge_signups_controller.rb +++ b/app/controllers/challenge_signups_controller.rb @@ -85,6 +85,7 @@ def index if params[:user_id] && (@user = User.find_by(login: params[:user_id])) if current_user == @user @challenge_signups = @user.challenge_signups.order_by_date + @page_subtitle = t(".page_title", username: @user.login) render action: :index and return else flash[:error] = ts("You aren't allowed to see that user's sign-ups.") diff --git a/config/locales/controllers/en.yml b/config/locales/controllers/en.yml index e1198536650..1f99beeaa15 100644 --- a/config/locales/controllers/en.yml +++ b/config/locales/controllers/en.yml @@ -116,6 +116,8 @@ en: challenge_signups: new: page_title: New Challenge Sign-up + index: + page_title: "%{username} - Challenge Sign-ups" chapters: destroy: only_chapter: You can't delete the only chapter in your work. If you want to delete the work, choose "Delete Work". diff --git a/spec/controllers/challenge_signups_controller_spec.rb b/spec/controllers/challenge_signups_controller_spec.rb index 3a3b3bdc644..ebaa75d532a 100644 --- a/spec/controllers/challenge_signups_controller_spec.rb +++ b/spec/controllers/challenge_signups_controller_spec.rb @@ -81,6 +81,14 @@ it_redirects_to_with_error(closed_collection, "You aren't allowed to see the CSV summary.") end + + context "when user visits their own sign-ups" do + it "sets the page subtitle correctly" do + fake_login_known_user(user) + get :index, params: { user_id: user.login } + expect(assigns(:page_subtitle)).to eq("#{user.login} - Challenge Sign-ups") + end + end end describe "destroy" do From af8b8f3c269afeef6d24938327f7687988730d4d Mon Sep 17 00:00:00 2001 From: lynn Date: Mon, 4 May 2026 16:18:04 -0700 Subject: [PATCH 2/2] AO3-7398 Fix em.yaml ordering --- config/locales/controllers/en.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/locales/controllers/en.yml b/config/locales/controllers/en.yml index 1f99beeaa15..2e3d19eed6e 100644 --- a/config/locales/controllers/en.yml +++ b/config/locales/controllers/en.yml @@ -114,10 +114,10 @@ en: index: page_title: "%{username} - Challenge Claims" challenge_signups: - new: - page_title: New Challenge Sign-up index: page_title: "%{username} - Challenge Sign-ups" + new: + page_title: New Challenge Sign-up chapters: destroy: only_chapter: You can't delete the only chapter in your work. If you want to delete the work, choose "Delete Work".