diff --git a/lib/otw_sanitize/embed_sanitizer.rb b/lib/otw_sanitize/embed_sanitizer.rb index a9ffaf55431..98e36aeea94 100644 --- a/lib/otw_sanitize/embed_sanitizer.rb +++ b/lib/otw_sanitize/embed_sanitizer.rb @@ -12,7 +12,6 @@ class EmbedSanitizer archiveorg: %r{^archive\.org/embed/}, bilibili: %r{^(player\.)?bilibili\.com/}, criticalcommons: %r{^criticalcommons\.org/}, - google: %r{^google\.com/}, podfic: %r{^podfic\.com/}, soundcloud: %r{^(w\.)?soundcloud\.com/}, spotify: %r{^(open\.)?spotify\.com/}, @@ -23,8 +22,8 @@ class EmbedSanitizer }.freeze ALLOWS_FLASHVARS = %i[ - criticalcommons eighttracks google - podfic soundcloud spotify viddersnet + criticalcommons eighttracks podfic + soundcloud spotify viddersnet ].freeze SUPPORTS_HTTPS = %i[ diff --git a/spec/lib/html_cleaner_spec.rb b/spec/lib/html_cleaner_spec.rb index 0c2eee160a3..64e8ea33dea 100644 --- a/spec/lib/html_cleaner_spec.rb +++ b/spec/lib/html_cleaner_spec.rb @@ -12,7 +12,7 @@ def one_cell_table(content) ArchiveConfig.FIELDS_ALLOWING_MEDIA_EMBEDS.each do |field| context "#{field} is configured to allow media embeds" do %w[youtube.com youtube-nocookie.com vimeo.com player.vimeo.com - vidders.net criticalcommons.org google.com podfic.com archive.org + vidders.net criticalcommons.org podfic.com archive.org open.spotify.com spotify.com w.soundcloud.com soundcloud.com viddertube.com bilibili.com player.bilibili.com 4shared.com/web/embed audio.com/embed/audio].each do |source| @@ -43,14 +43,6 @@ def one_cell_table(content) end end - it "keeps google player embeds without closing tag" do - # HTML5 disallows , according to https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/embed#technical_summary - html1 = '' - html2 = "#{html1}" - result = sanitize_value(field, html2) - expect(result).to eq(html1) - end - it "strips embeds with unknown source" do html = '' result = sanitize_value(field, html)