Skip to content

Commit fcc3ff1

Browse files
committed
fix lint
Signed-off-by: Tomáš Remeš <tremes@redhat.com>
1 parent 5d552c5 commit fcc3ff1

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

timeserieschart/src/TimeSeriesChartBase.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// See the License for the specific language governing permissions and
1212
// limitations under the License.
1313

14-
import { forwardRef, MouseEvent, useEffect, useImperativeHandle, useMemo, useRef, useState } from 'react';
14+
import { forwardRef, MouseEvent, useCallback, useEffect, useImperativeHandle, useMemo, useRef, useState } from 'react';
1515
import { Box } from '@mui/material';
1616
import merge from 'lodash/merge';
1717
import isEqual from 'lodash/isEqual';
@@ -58,8 +58,8 @@ import {
5858
useTimeZone,
5959
ZoomEventData,
6060
} from '@perses-dev/components';
61-
import { createTimezoneAwareAxisFormatter } from './utils/timezone-formatter';
6261
import { DatasetOption } from 'echarts/types/dist/shared';
62+
import { createTimezoneAwareAxisFormatter } from './utils/timezone-formatter';
6363

6464
use([
6565
EChartsLineChart,
@@ -128,8 +128,10 @@ export const TimeSeriesChartBase = forwardRef<ChartInstance, TimeChartProps>(fun
128128
const [startX, setStartX] = useState(0);
129129
const { timeZone } = useTimeZone();
130130

131-
const getTimezoneAwareAxisFormatter = (rangeMs: number) =>
132-
createTimezoneAwareAxisFormatter(rangeMs, timeZone);
131+
const getTimezoneAwareAxisFormatter = useCallback(
132+
(rangeMs: number): ((value: number) => string) => createTimezoneAwareAxisFormatter(rangeMs, timeZone),
133+
[timeZone]
134+
);
133135

134136
let timeScale: TimeScale;
135137
if (timeScaleProp === undefined) {
@@ -278,10 +280,10 @@ export const TimeSeriesChartBase = forwardRef<ChartInstance, TimeChartProps>(fun
278280
noDataOption,
279281
__experimentalEChartsOptionsOverride,
280282
noDataVariant,
281-
timeZone,
282283
isStackedBar,
283284
enablePinning,
284285
pinnedCrosshair,
286+
getTimezoneAwareAxisFormatter,
285287
]);
286288

287289
// Update adjacent charts so tooltip is unpinned when current chart is clicked.

timeserieschart/src/utils/timezone-formatter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,4 @@ describe('createTimezoneAwareAxisFormatter', () => {
7676
// Should use HH:mm format (not > 2 days)
7777
expect(result).toBe('HH:mm[America/New_York]');
7878
});
79-
});
79+
});

timeserieschart/src/utils/timezone-formatter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ export function createTimezoneAwareAxisFormatter(rangeMs: number, timeZone: stri
4646

4747
return formatWithTimeZone(timeStamp, 'HH:mm', timeZone);
4848
};
49-
}
49+
}

0 commit comments

Comments
 (0)