fix: don't restrict interface gateway assignment by id

Addresses an issue that prevented gateways from being assigned to an interface when the REST API 'represent_interfaces_as' setting was not set to 'id'. Previously the related RoutingGateway model query used the interface's literal id value, but when interfaces are not represented by its id the query will always return nothing, therefor a gateway cannot be assigned

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/NetworkInterface.inc

@@ -165,7 +165,7 @@ class NetworkInterface extends Model {
         $this->gateway = new ForeignModelField(
             model_name: ['RoutingGateway', 'RoutingGatewayGroup'],
             model_field: 'name',
-            model_query: ['ipprotocol' => 'inet', 'interface' => &$this->id],
+            model_query: ['ipprotocol' => 'inet'],
             allow_null: true,
             conditions: ['typev4' => 'static'],
             help_text: 'Sets the upstream gateway this interface will use. This is only applicable for WAN-type interfaces.',
@@ -313,7 +313,7 @@ class NetworkInterface extends Model {
         $this->gatewayv6 = new ForeignModelField(
             model_name: ['RoutingGateway', 'RoutingGatewayGroup'],
             model_field: 'name',
-            model_query: ['ipprotocol' => 'inet6', 'interface' => &$this->id],
+            model_query: ['ipprotocol' => 'inet6'],
             allow_null: true,
             conditions: ['typev6' => 'staticv6'],
             help_text: 'Sets the upstream IPv6 gateway this interface will use. This is only applicable for WAN-type interfaces.',