chore: fix errors from shellcheck

There were the following messages:
- Double quote to prevent globbing and word splitting. [SC2086]
- seconds appears unused. Verify use (or export if used externally). [SC2034]
- Use $((..)) instead of deprecated $[..] [SC2007]

Correction for 7e2cb42 commit.

Author: php-coder

src/main/scripts/ci/check-build-and-verify.sh

@@ -29,11 +29,11 @@ print_status() {
 	fi
 
 	local time=
-	if [ $execution_time -gt 0 ]; then
-		local mins seconds
-		mins=$[execution_time / 60]
-		secs=$[execution_time % 60]
-		if [ $mins -eq 0 ]; then
+	if [ "$execution_time" -gt 0 ]; then
+		local mins secs
+		mins=$((execution_time / 60))
+		secs=$((execution_time % 60))
+		if [ "$mins" -eq 0 ]; then
 			time="$(printf '%2ss' "$secs")"
 		else
 			time="$(printf '%2sm%2ds' "$mins" "$secs")"
@@ -180,114 +180,114 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
 	if [ "$CS_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" checkstyle >cs.log 2>&1 || CS_STATUS=fail
-		CS_TIME=$[SECONDS-START_TIME]
+		CS_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$CS_STATUS" "$CS_TIME" 'Run CheckStyle'
 
 	if [ "$PMD_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" pmd >pmd.log 2>&1 || PMD_STATUS=fail
-		PMD_TIME=$[SECONDS-START_TIME]
+		PMD_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$PMD_STATUS" "$PMD_TIME" 'Run PMD'
 
 	if [ "$LICENSE_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" check-license >license.log 2>&1 || LICENSE_STATUS=fail
-		LICENSE_TIME=$[SECONDS-START_TIME]
+		LICENSE_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$LICENSE_STATUS" "$LICENSE_TIME" 'Check license headers'
 
 	if [ "$POM_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" check-pom >pom.log 2>&1 || POM_STATUS=fail
-		POM_TIME=$[SECONDS-START_TIME]
+		POM_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$POM_STATUS" "$POM_TIME" 'Check sorting of pom.xml'
 
 	if [ "$BOOTLINT_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" bootlint >bootlint.log 2>&1 || BOOTLINT_STATUS=fail
-		BOOTLINT_TIME=$[SECONDS-START_TIME]
+		BOOTLINT_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$BOOTLINT_STATUS" "$BOOTLINT_TIME" 'Run bootlint'
 
 	if [ "$RFLINT_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" rflint >rflint.log 2>&1 || RFLINT_STATUS=fail
-		RFLINT_TIME=$[SECONDS-START_TIME]
+		RFLINT_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$RFLINT_STATUS" "$RFLINT_TIME" 'Run robot framework lint'
 
 	if [ "$SHELLCHECK_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" shellcheck >shellcheck.log 2>&1 || SHELLCHECK_STATUS=fail
-		SHELLCHECK_TIME=$[SECONDS-START_TIME]
+		SHELLCHECK_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$SHELLCHECK_STATUS" "$SHELLCHECK_TIME" 'Run shellcheck'
 
 	if [ "$JASMINE_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" jasmine >jasmine.log 2>&1 || JASMINE_STATUS=fail
-		JASMINE_TIME=$[SECONDS-START_TIME]
+		JASMINE_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$JASMINE_STATUS" "$JASMINE_TIME" 'Run JavaScript unit tests'
 
 	if [ "$HTML_STATUS" != 'skip' ]; then
 		"$EXEC_CMD" html5validator >validator.log 2>&1 || HTML_STATUS=fail
-		HTML_TIME=$[SECONDS-START_TIME]
+		HTML_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$HTML_STATUS" "$HTML_TIME" 'Run html5validator'
 
 	if [ "$ENFORCER_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" enforcer >enforcer.log 2>&1 || ENFORCER_STATUS=fail
-		ENFORCER_TIME=$[SECONDS-START_TIME]
+		ENFORCER_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$ENFORCER_STATUS" "$ENFORCER_TIME" 'Run maven-enforcer-plugin'
 
 	if [ "$TEST_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" unit-tests >test.log 2>&1 || TEST_STATUS=fail
-		TEST_TIME=$[SECONDS-START_TIME]
+		TEST_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$TEST_STATUS" "$TEST_TIME" 'Run unit tests'
 
 	if [ "$CODENARC_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		# run after tests for getting compiled sources
 		"$EXEC_CMD" codenarc >codenarc.log 2>&1 || CODENARC_STATUS=fail
-		CODENARC_TIME=$[SECONDS-START_TIME]
+		CODENARC_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$CODENARC_STATUS" "$CODENARC_TIME" 'Run CodeNarc'
 
 	if [ "$SPOTBUGS_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		# run after tests for getting compiled sources
 		"$EXEC_CMD" spotbugs >spotbugs.log 2>&1 || SPOTBUGS_STATUS=fail
-		SPOTBUGS_TIME=$[SECONDS-START_TIME]
+		SPOTBUGS_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$SPOTBUGS_STATUS" "$SPOTBUGS_TIME" 'Run SpotBugs'
 
 	if [ "$ANSIBLE_LINT_STATUS" != 'skip' ]; then
 		START_TIME=$SECONDS
 		"$EXEC_CMD" ansible-lint >ansible_lint.log 2>&1 || ANSIBLE_LINT_STATUS=fail
-		ANSIBLE_LINT_TIME=$[SECONDS-START_TIME]
+		ANSIBLE_LINT_TIME=$((SECONDS - START_TIME))
 	fi
 	print_status "$ANSIBLE_LINT_STATUS" $ANSIBLE_LINT_TIME 'Run Ansible Lint'
 fi
 
 START_TIME=$SECONDS
 "$EXEC_CMD" integration-tests >verify.log 2>&1 || VERIFY_STATUS=fail
-VERIFY_TIME=$[SECONDS-START_TIME]
+VERIFY_TIME=$((SECONDS - START_TIME))
 
 print_status "$VERIFY_STATUS" "$VERIFY_TIME" 'Run integration tests'
 
 
 if [ "$DANGER_STATUS" != 'skip' ]; then
 	START_TIME=$SECONDS
 	"$EXEC_CMD" danger >danger.log 2>&1 || DANGER_STATUS=fail
-	DANGER_TIME=$[SECONDS-START_TIME]
+	DANGER_TIME=$((SECONDS - START_TIME))
 fi
 print_status "$DANGER_STATUS" "$DANGER_TIME" 'Run danger'