improve: extract a price when it contains a comma and a point in the same time (for example, 1,218.79)

Author: php-coder

src/main/java/ru/mystamps/web/feature/series/importing/SeriesInfoExtractorServiceImpl.java

@@ -421,6 +421,7 @@ public SeriesExtractedInfo extract(String pageUrl, RawParsedDataDto data) {
 	@SuppressWarnings({
 		"PMD.AvoidInstantiatingObjectsInLoops",
 		"PMD.AvoidReassigningParameters",
+		"PMD.NPathComplexity",
 		"checkstyle:parameterassignment"
 	})
 	/* default */ BigDecimal extractPrice(String fragment) {
@@ -441,9 +442,14 @@ public SeriesExtractedInfo extract(String pageUrl, RawParsedDataDto data) {
 
 		String[] candidates = StringUtils.split(fragment, ' ');
 		for (String candidate : candidates) {
-			// replace comma with dot to handle 10,5 in the same way as 10.5
 			if (candidate.contains(",")) {
-				candidate = StringUtils.replaceChars(candidate, ',', '.');
+				if (candidate.contains(".")) {
+					// "1,218.79" => "1218.79"
+					candidate = StringUtils.remove(candidate, ',');
+				} else {
+					// replace comma with dot to handle 10,5 in the same way as 10.5
+					candidate = StringUtils.replaceChars(candidate, ',', '.');
+				}
 			}
 			// "10$" -> "10"
 			if (candidate.endsWith(postfix) && candidate.length() > postfix.length()) {

src/test/groovy/ru/mystamps/web/feature/series/importing/SeriesInfoExtractorServiceImplTest.groovy

@@ -661,6 +661,7 @@ class SeriesInfoExtractorServiceImplTest extends Specification {
 			'10.00 EUR'     | BigDecimal.TEN
 			'10,00 EUR'     | BigDecimal.TEN
 			'10 руб 16 коп' | BigDecimal.TEN
+			'RUB 1,218.79'  | new BigDecimal('1218.79')
 	}
 
 	@Unroll