From f98c22f4f0fca6a98ec77c19330c2801ae558c7e Mon Sep 17 00:00:00 2001 From: Daniel Scherzer Date: Fri, 12 Dec 2025 23:24:05 -0800 Subject: [PATCH] ext/standard: "double" is not deprecated for `settype()` Remove incorrect inline comment that using "double" as the type is deprecated; this comment was added in 929ae94c64c71fcbed8e4cecdb6d09398d61e079 when support for "float" was included, but the use of "double" was never actually deprecated. [skip ci] --- ext/standard/type.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/standard/type.c b/ext/standard/type.c index c05926b1a3770..ff35cb785cce9 100644 --- a/ext/standard/type.c +++ b/ext/standard/type.c @@ -105,7 +105,7 @@ PHP_FUNCTION(settype) convert_to_long(ptr); } else if (zend_string_equals_ci(type, ZSTR_KNOWN(ZEND_STR_FLOAT))) { convert_to_double(ptr); - } else if (zend_string_equals_ci(type, ZSTR_KNOWN(ZEND_STR_DOUBLE))) { /* deprecated */ + } else if (zend_string_equals_ci(type, ZSTR_KNOWN(ZEND_STR_DOUBLE))) { convert_to_double(ptr); } else if (zend_string_equals_ci(type, ZSTR_KNOWN(ZEND_STR_STRING))) { convert_to_string(ptr);