feat: add dark mode and theme switching support by Ansita20 · Pull Request #6766 · pipe-cd/pipecd

Ansita20 · 2026-05-12T17:52:08Z

Pull Request: Implement Dark Mode Theme Switching

Overview

This PR adds comprehensive dark mode support to the PipeCD web application with a centralized theme management system, automatic system preference detection, and localStorage persistence.

Changes Made

New Files Created

1. web/src/contexts/ThemeContext.tsx

Created ThemeContext with TypeScript support
Implemented ThemeProvider component that wraps the app
Added useTheme() hook for accessing theme state
Features:
Theme mode switching (light/dark)
Automatic system theme detection via prefers-color-scheme
localStorage persistence with key pipecd-theme-mode
HTML attribute updates for CSS-based styling support
Proper error handling for missing context

2. web/src/components/theme/ThemeToggle.tsx

Created reusable ThemeToggle component
Icon button with DarkMode/LightMode icons from @mui/icons-material
Tooltip showing next theme mode
Compact styling suitable for header integration
Accessible with proper ARIA labels

Modified Files

1. web/src/theme.ts

Refactored into separate light and dark theme variants
Created lightTheme object with light color palette
Created darkTheme object with dark color palette
Added getTheme() helper function for dynamic theme selection
Extracted common component styles to commonComponents constant
Maintained backward compatibility with default theme export
Added proper text and background colors for both modes
Colors:
Light: Primary #283778, Success #539d56, Error #d6442c
Dark: Primary #6fa3ff, Success #66bb6a, Error #ef5350

2. web/src/index.tsx

Replaced MUI's ThemeProvider with custom ThemeProvider from ThemeContext
Removed CssBaseline import (now handled by ThemeContext)
Updated imports to use ThemeProvider from contexts
Simplified provider hierarchy

3. web/src/components/header/index.tsx

Added import: import ThemeToggle from "~/components/theme/ThemeToggle";
Added <ThemeToggle /> component in the header's right-side action box
Positioned before navigation links for visibility on all pages
Works on both login and authenticated pages

4. web/webpack.config.dev.js

Added /auth to proxy context alongside /api
Enables proper routing of authentication endpoints in development
Fixes Cannot POST /auth/login error during local development

Technical Details

Theme Architecture

ThemeProvider (ThemeContext.tsx)
 ├── Manages theme mode state
 ├── Handles localStorage persistence
 ├── Detects system preference
 └── Wraps MUI's ThemeProvider


useTheme() Hook
 ├── Returns { mode, toggleTheme, setTheme }
 └── Used by ThemeToggle and any component needing theme


Theme Objects (theme.ts)
 ├── lightTheme
 ├── darkTheme
 └── getTheme(mode) -> Theme

Data Flow

User clicks ThemeToggle icon
toggleTheme() updates state in ThemeContext
Theme preference saved to localStorage
getTheme() returns appropriate MUI theme
MUI re-renders all components with new theme
Optional: HTML data-theme attribute updated for CSS hooks

Browser API Usage

localStorage for persistence
window.matchMedia('(prefers-color-scheme: dark)') for system detection
document.documentElement.setAttribute('data-theme', mode) for CSS integration

Testing Checklist

TypeScript compilation passes
No lint errors
Theme toggle renders in header
Theme persists on page reload
System theme detection works on first visit
Dark mode colors are readable and accessible
Theme switch works on login page
Theme switch works on authenticated pages
/auth proxy works in dev environment

Browser Compatibility

Chrome/Edge: 76+
Firefox: 67+
Safari: 12.1+
Mobile browsers: iOS Safari 12.2+, Chrome Mobile 76+

Performance Impact

No breaking changes
ThemeProvider adds minimal overhead (context subscription only)
Theme switching is instant (no network requests)
localStorage operations are synchronous and fast

Accessibility

Theme toggle button includes ARIA labels
Tooltip explains the toggle function
Dark mode maintains WCAG AA contrast ratios
Respects user's system preference by default

Documentation

Usage for Developers

import { useTheme } from './contexts/ThemeContext';


function MyComponent() {
 const { mode, toggleTheme, setTheme } = useTheme();
  return (
   <button onClick={toggleTheme}>
     Current mode: {mode}
   </button>
 );
}

For End Users

Click the sun/moon icon in the header to toggle theme
Theme preference is saved automatically
On first visit, respects your system setting

Breaking Changes

None. The theme export from theme.ts is maintained for backward compatibility.

Related Issues

Closes #[Issue Number - Dark Mode Support]

Screenshots

[Login page with light theme]
[Login page with dark theme]
[Header with theme toggle button]

Reviewers

@pipe-cd/maintainers

Deployment Notes

No database migrations needed
No environment variable changes
Works with existing authentication system
Compatible with current webpack configuration

Future Improvements

Add theme selection dropdown for additional variants
Create custom theme builder UI
Add transition animations for theme switch
Support CSS variables for component-level customization
Add theme color picker for branding
Document dark mode guidelines for component contributors

fixes issue : #6765

Signed-off-by: ansita20 <ansitasingh20@gmail.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds dark mode support with centralized theme state management, persistence, and a header toggle, plus a dev proxy tweak for auth endpoints.

Changes:

Introduces a ThemeContext provider/hook to manage light/dark mode with persistence and system preference support.
Splits MUI theme into lightTheme/darkTheme and adds a ThemeToggle in the header.
Updates dev webpack proxy to include /auth routes.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web/webpack.config.dev.js	Proxies `/auth` alongside `/api` for dev auth routing.
web/src/theme.ts	Adds light/dark theme variants and a helper to select by mode.
web/src/index.tsx	Switches app wiring to use the custom `ThemeProvider` (context-managed).
web/src/contexts/ThemeContext.tsx	New context/provider implementing theme mode, persistence, and system detection.
web/src/components/theme/ThemeToggle.tsx	New header-friendly theme toggle button component.
web/src/components/header/index.tsx	Adds the toggle to the header actions area.
web/package.json	Adds `ajv` and `ajv-keywords` dependencies.

+  // Persist theme mode to localStorage
+  useEffect(() => {
+    localStorage.setItem(THEME_STORAGE_KEY, mode);
+    // Update HTML attribute for CSS-based styling if needed
+    if (typeof window !== "undefined") {
+      document.documentElement.setAttribute("data-theme", mode);
+    }
+  }, [mode]);
+
+  // Listen to system theme changes
+  useEffect(() => {
+    const mediaQuery = window.matchMedia("(prefers-color-scheme: dark)");
+    const handleChange = (e: MediaQueryListEvent) => {
+      const stored = localStorage.getItem(THEME_STORAGE_KEY);
+      // Only update if user hasn't explicitly set a preference
+      if (!stored) {
+        setMode(e.matches ? "dark" : "light");
+      }
+    };


+  useEffect(() => {
+    const mediaQuery = window.matchMedia("(prefers-color-scheme: dark)");
+    const handleChange = (e: MediaQueryListEvent) => {
+      const stored = localStorage.getItem(THEME_STORAGE_KEY);
+      // Only update if user hasn't explicitly set a preference
+      if (!stored) {
+        setMode(e.matches ? "dark" : "light");
+      }
+    };
+
+    mediaQuery.addEventListener("change", handleChange);
+    return () => mediaQuery.removeEventListener("change", handleChange);
+  }, []);


+
+  return (
+    <Tooltip title={`Switch to ${mode === "light" ? "dark" : "light"} mode`}>
+      <IconButton onClick={toggleTheme} size="small" color="inherit">


+export const useTheme = (): ThemeContextType => {
+  const context = useContext(ThemeContext);
+  if (context === undefined) {
+    throw new Error("useTheme must be used within a ThemeProvider");


+    "ajv": "^8.20.0",
+    "ajv-keywords": "^5.1.0",


Ayushmore1214

@Ansita20 this is a huge change, can you run this locally and share screen recording and screenshots ?

Ansita20 · 2026-05-13T16:16:41Z

@Ansita20 this is a huge change, can you run this locally and share screen recording and screenshots ?

yess I will share the image...the mode changes according to the system settings.
Is that fine or should I add a toggle for the dark light mdoe?

Ayushmore1214 · 2026-05-13T16:54:02Z

go with system setting one first if it works well we can look ahead!

Copilot AI review requested due to automatic review settings May 12, 2026 17:52

Ansita20 requested review from a team as code owners May 12, 2026 17:52

Ansita20 requested review from Warashi, ffjlabo, hongky-1994 and khanhtc1202 May 12, 2026 17:52

github-actions Bot added the area/web label May 12, 2026

feat: add dark mode and theme switching support

bc61417

Signed-off-by: ansita20 <ansitasingh20@gmail.com>

Ansita20 force-pushed the feature/dark-mode-theme-switching branch from 66afaa0 to bc61417 Compare May 12, 2026 17:58

Copilot AI reviewed May 12, 2026

View reviewed changes

Ayushmore1214 reviewed May 13, 2026

View reviewed changes

Ayushmore1214 mentioned this pull request May 14, 2026

#6765 issue is fixed Added Dark Mode Support and Theming Consistency #6771

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add dark mode and theme switching support#6766

feat: add dark mode and theme switching support#6766
Ansita20 wants to merge 1 commit into
pipe-cd:masterfrom
Ansita20:feature/dark-mode-theme-switching

Ansita20 commented May 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Ayushmore1214 left a comment

Uh oh!

Ansita20 commented May 13, 2026

Uh oh!

Ayushmore1214 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Ansita20 commented May 12, 2026

Pull Request: Implement Dark Mode Theme Switching

Overview

Changes Made

New Files Created

1. web/src/contexts/ThemeContext.tsx

2. web/src/components/theme/ThemeToggle.tsx

Modified Files

1. web/src/theme.ts

2. web/src/index.tsx

3. web/src/components/header/index.tsx

4. web/webpack.config.dev.js

Technical Details

Theme Architecture

Data Flow

Browser API Usage

Testing Checklist

Browser Compatibility

Performance Impact

Accessibility

Documentation

Usage for Developers

For End Users

Breaking Changes

Related Issues

Screenshots

Reviewers

Deployment Notes

Future Improvements

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Ayushmore1214 left a comment

Choose a reason for hiding this comment

Uh oh!

Ansita20 commented May 13, 2026

Uh oh!

Ayushmore1214 commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants