Skip to content

Commit 925e465

Browse files
committed
remove node 18 build job (use node 22 only)
1 parent 41bbed9 commit 925e465

2 files changed

Lines changed: 3 additions & 38 deletions

File tree

.github/workflows/publish-dist.yml

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -16,41 +16,6 @@ concurrency:
1616

1717
jobs:
1818
publish-dist:
19-
runs-on: ubuntu-latest
20-
steps:
21-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
22-
with:
23-
fetch-depth: 0
24-
fetch-tags: true
25-
26-
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
27-
with:
28-
node-version: '18'
29-
cache: 'npm'
30-
31-
- name: Set up build environment
32-
run: .github/scripts/env_build.sh
33-
34-
- name: Set draft version in package.json
35-
run: |
36-
node --eval "var fs = require('fs'); var inOut = './package.json'; var data = JSON.parse(fs.readFileSync(inOut)); var a = process.argv; data.version = a[a.length - 1].replace('v', ''); fs.writeFileSync(inOut, JSON.stringify(data, null, 2) + '\n');" $(git describe)
37-
# View package.json diff from last release (should show that the version has been changed to the draft version)
38-
git --no-pager diff --color-words tags/$(git describe --tags --abbrev=0) package.json || true
39-
40-
- name: Build dist/
41-
run: npm run build
42-
43-
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
44-
name: Upload Node 18 archive of plotly.js build folder
45-
with:
46-
name: dist-node18
47-
retention-days: 7
48-
path: dist/
49-
50-
- name: Test plot-schema.json diff
51-
run: diff --unified --color dist/plot-schema.json test/plot-schema.json
52-
53-
publish-dist-node-v22:
5419
runs-on: ubuntu-latest
5520
steps:
5621
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -76,9 +41,9 @@ jobs:
7641
run: npm run build
7742

7843
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
79-
name: Upload Node 22 archive of plotly.js build folder
44+
name: Upload archive of plotly.js build artifacts (contents of dist/)
8045
with:
81-
name: dist-node22
46+
name: dist
8247
retention-days: 7
8348
path: dist/
8449

.github/workflows/upload-dev-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
id: download-artifact
3030
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
3131
with:
32-
name: dist-node22 # uploaded by publish-dist.yml > publish-dist-node-v22
32+
name: dist # uploaded by publish-dist.yml > publish-dist
3333
run-id: ${{ github.event.workflow_run.id || inputs.run_id }}
3434
github-token: ${{ secrets.GITHUB_TOKEN }}
3535
path: temp-dist

0 commit comments

Comments
 (0)