From 5f0972df66cb34d90523b951d6e9ca49de025343 Mon Sep 17 00:00:00 2001 From: Lionel Henry Date: Fri, 3 Apr 2026 22:49:33 +0200 Subject: [PATCH] Rename `positron.error_entrace` to `ark.error_entrace` --- crates/ark/src/modules/positron/errors.R | 8 ++++---- crates/ark/tests/kernel-execute.rs | 2 +- doc/configuration.md | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/ark/src/modules/positron/errors.R b/crates/ark/src/modules/positron/errors.R index d4df89356..99b2fb023 100644 --- a/crates/ark/src/modules/positron/errors.R +++ b/crates/ark/src/modules/positron/errors.R @@ -44,7 +44,7 @@ return(handle_error_base(cnd)) } - if (!inherits(cnd, "rlang_error") && !positron_option_error_entrace()) { + if (!inherits(cnd, "rlang_error") && !option_ark_error_entrace()) { # We have a non-rlang error, but the user requested we dont entrace it return(handle_error_base(cnd)) } @@ -192,9 +192,9 @@ handle_error_rlang <- function(cnd) { .ps.Call("ps_record_error", evalue, traceback) } -positron_option_error_entrace <- function() { - # TODO: Wire this up to a Positron option for easy toggling? - isTRUE(getOption("positron.error_entrace", default = TRUE)) +option_ark_error_entrace <- function() { + # TODO: Wire this up to a Positron setting for easy toggling? + isTRUE(getOption("ark.error_entrace", default = TRUE)) } rust_backtrace <- function() { diff --git a/crates/ark/tests/kernel-execute.rs b/crates/ark/tests/kernel-execute.rs index 0330d8ff8..95e76af23 100644 --- a/crates/ark/tests/kernel-execute.rs +++ b/crates/ark/tests/kernel-execute.rs @@ -33,7 +33,7 @@ fn test_execute_request_incomplete() { let frontend = DummyArkFrontend::lock(); - frontend.execute_request_invisibly("options(positron.error_entrace = FALSE)"); + frontend.execute_request_invisibly("options(ark.error_entrace = FALSE)"); frontend.execute_request_error("1 +", |error_msg| { assert_eq!(error_msg, "Error:\nCan't parse incomplete input"); diff --git a/doc/configuration.md b/doc/configuration.md index 309ad562c..18cf03c27 100644 --- a/doc/configuration.md +++ b/doc/configuration.md @@ -42,7 +42,7 @@ A boolean, with a default value of `FALSE`. If `TRUE`, the special `.Last.value` will be shown in Positron's Variables pane. -## `positron.error_entrace` +## `ark.error_entrace` A boolean, with a default value of `TRUE`.