fix(website): fix index page layout rendering#66
Draft
ian-flores wants to merge 4 commits intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the website’s broken index-page layout by changing how global CSS and Google Fonts are loaded so that styles aren’t discarded when Astro inlines style blocks.
Changes:
- Removed Google Fonts loading via CSS
@importfromglobal.css. - Switched global CSS inclusion to an Astro frontmatter
importin the shared layout. - Added Google Fonts
<link>(with preconnect hints) to the document<head>.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
website/src/styles/global.css |
Removes Google Fonts @import so fonts are no longer loaded via inlined CSS. |
website/src/layouts/Layout.astro |
Imports global CSS in frontmatter and loads Google Fonts via <link> tags in <head>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
The report and website previews both use rossjrw/pr-preview-action which posts a sticky comment. Without distinct comment-tag values, one overwrites the other. Now each preview gets its own PR comment.
rossjrw/pr-preview-action doesn't support comment-tag, so both previews shared the same sticky comment and one overwrote the other. Disable the built-in comment on the website preview and use marocchino/sticky-pull-request-comment directly with a distinct header.
|
Website Preview · View preview |
Collaborator
|
thanks for fixing this! I noticed the issue during a demo earlier today and hadn't gotten to fire off an agent yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<style is:global>@importwith Astro's recommended frontmatterimportfor global CSS@import url()to<link>tags in<head>(spec-compliant, parallel loading)@importbeing discarded inside inlined<style>blocksTest plan
cd website && npm ci && npm run buildsucceedsdist/index.htmlcontains Google Fonts<link>tag and CSS variables resolve