Skip to content

Commit 8e8e4e1

Browse files
Radiokotsimolus3stevensJourney
authored
Fix some logging issues (#242)
* Do not modify global Kermit severity * Add 'PowerSync' tag for the logs * Get rid of generateLogger() * Fix lint issues * Apply format * Revert "Get rid of generateLogger()" This reverts commit 826e7a3. * Update core/src/commonMain/kotlin/com/powersync/utils/Log.kt --------- Co-authored-by: Simon Binder <simon@journeyapps.com> Co-authored-by: stevensJourney <51082125+stevensJourney@users.noreply.github.com>
1 parent 48efa34 commit 8e8e4e1

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
* Add `PowerSyncDatabase.getCrudTransactions()`, returning a flow of transactions. This is useful
66
to upload multiple transactions in a batch.
7+
* Fix modifying severity of the global Kermit logger
8+
* Add `PowerSync` tag for the logs
79

810
## 1.4.0
911

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,28 @@
11
package com.powersync.utils
22

3+
import BuildConfig
34
import co.touchlab.kermit.Logger
45
import co.touchlab.kermit.Severity
6+
import co.touchlab.kermit.StaticConfig
7+
import co.touchlab.kermit.platformLogWriter
58

69
/*
710
* Generates a logger with the appropriate severity level based on the build type
811
* if no Logger is provided.
912
*/
10-
public fun generateLogger(logger: Logger?): Logger {
11-
if (logger != null) {
12-
return logger
13-
}
14-
15-
val defaultLogger: Logger = Logger
16-
17-
if (BuildConfig.isDebug) {
18-
Logger.setMinSeverity(Severity.Verbose)
19-
} else {
20-
Logger.setMinSeverity(Severity.Warn)
21-
}
22-
23-
return defaultLogger
24-
}
13+
public fun generateLogger(logger: Logger?): Logger =
14+
logger
15+
?: Logger(
16+
config =
17+
StaticConfig(
18+
logWriterList =
19+
listOf(platformLogWriter()),
20+
minSeverity =
21+
if (BuildConfig.isDebug) {
22+
Severity.Verbose
23+
} else {
24+
Severity.Warn
25+
},
26+
),
27+
tag = "PowerSync",
28+
)

0 commit comments

Comments
 (0)