Cleanup.

Author: rkistner

crates/core/src/operations.rs

@@ -1,12 +1,11 @@
 use alloc::format;
-use alloc::string::{String, ToString};
+use alloc::string::String;
 
 use crate::error::{PSResult, SQLiteError};
 use sqlite_nostd as sqlite;
 use sqlite_nostd::{Connection, ResultCode};
 
 use crate::ext::SafeManagedStmt;
-use crate::util::*;
 
 // Run inside a transaction
 pub fn insert_operation(db: *mut sqlite::sqlite3, data: &str) -> Result<(), SQLiteError> {
@@ -145,7 +144,7 @@ INSERT OR IGNORE INTO ps_updated_rows(row_type, row_id) VALUES(?1, ?2)",
             }
             supersede_statement.reset()?;
 
-            if (op == "REMOVE") {
+            if op == "REMOVE" {
                 let should_skip_remove = !superseded;
 
                 add_checksum = add_checksum.wrapping_add(checksum);
@@ -251,13 +250,13 @@ WHERE bucket = ?1",
     Ok(())
 }
 
-pub fn clear_remove_ops(db: *mut sqlite::sqlite3, _data: &str) -> Result<(), SQLiteError> {
+pub fn clear_remove_ops(_db: *mut sqlite::sqlite3, _data: &str) -> Result<(), SQLiteError> {
     // No-op
 
     Ok(())
 }
 
-pub fn delete_pending_buckets(db: *mut sqlite::sqlite3, _data: &str) -> Result<(), SQLiteError> {
+pub fn delete_pending_buckets(_db: *mut sqlite::sqlite3, _data: &str) -> Result<(), SQLiteError> {
     // No-op
 
     Ok(())

crates/core/src/schema_management.rs

@@ -13,7 +13,6 @@ use sqlite_nostd::Context;
 use crate::error::{PSResult, SQLiteError};
 use crate::ext::ExtendedDatabase;
 use crate::util::{quote_identifier, quote_json_path};
-use crate::view_admin::powersync_init_impl;
 use crate::{create_auto_tx_function, create_sqlite_text_fn};
 
 fn update_tables(db: *mut sqlite::sqlite3, schema: &str) -> Result<(), SQLiteError> {
@@ -303,8 +302,7 @@ fn powersync_replace_schema_impl(
     let db = ctx.db_handle();
 
     // language=SQLite
-    // db.exec_safe("SELECT powersync_init()").into_db_result(db)?;
-    powersync_init_impl(ctx, args);
+    db.exec_safe("SELECT powersync_init()").into_db_result(db)?;
 
     update_tables(db, schema)?;
     update_indexes(db, schema)?;

crates/core/src/view_admin.rs

@@ -111,7 +111,7 @@ create_sqlite_text_fn!(
     "powersync_external_table_name"
 );
 
-pub fn powersync_init_impl(
+fn powersync_init_impl(
     ctx: *mut sqlite::context,
     _args: &[*mut sqlite::value],
 ) -> Result<String, SQLiteError> {