From 454b80a5924a7eb3706535ed2e6fd12cf4d3533c Mon Sep 17 00:00:00 2001 From: Kenneth Young Date: Mon, 13 Apr 2026 12:11:14 -0700 Subject: [PATCH 1/7] test commit --- test.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 test.txt diff --git a/test.txt b/test.txt new file mode 100644 index 0000000000..b6fc4c620b --- /dev/null +++ b/test.txt @@ -0,0 +1 @@ +hello \ No newline at end of file From ae2afc933fcbd9f9fa79ab25281718c66cf78951 Mon Sep 17 00:00:00 2001 From: kennethyyoung <65055823+kennethyyoung@users.noreply.github.com> Date: Mon, 20 Apr 2026 11:18:59 -0700 Subject: [PATCH 2/7] Add brainstorming notes for navigation components --- !brainstorming.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 !brainstorming.md diff --git a/!brainstorming.md b/!brainstorming.md new file mode 100644 index 0000000000..9e5060889f --- /dev/null +++ b/!brainstorming.md @@ -0,0 +1,6 @@ +Underline logic for subsection links (eg. Input and Button) located in src/components/Nav/JumpToLinks.tsx +CSS in the same folder (styles.modules.scss) +Main Nav links related files + src/components/Nav/index.astro + src/components/Nav/MainNavLinks.tsx + src/components/Nav/NavPanels From 3a07b448dd61a71046e9aaa0ab652474f07499fe Mon Sep 17 00:00:00 2001 From: kennethyyoung <65055823+kennethyyoung@users.noreply.github.com> Date: Mon, 20 Apr 2026 11:20:40 -0700 Subject: [PATCH 3/7] Delete test.txt --- test.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 test.txt diff --git a/test.txt b/test.txt deleted file mode 100644 index b6fc4c620b..0000000000 --- a/test.txt +++ /dev/null @@ -1 +0,0 @@ -hello \ No newline at end of file From 57b7ab929a59071a05d3fc12b40827febe3cf418 Mon Sep 17 00:00:00 2001 From: kennethyyoung <65055823+kennethyyoung@users.noreply.github.com> Date: Mon, 20 Apr 2026 11:25:41 -0700 Subject: [PATCH 4/7] Update brainstorming notes for navigation links Organize and clarify main navigation link files and requirements. --- !brainstorming.md | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/!brainstorming.md b/!brainstorming.md index 9e5060889f..b73770d5fb 100644 --- a/!brainstorming.md +++ b/!brainstorming.md @@ -1,6 +1,13 @@ Underline logic for subsection links (eg. Input and Button) located in src/components/Nav/JumpToLinks.tsx + CSS in the same folder (styles.modules.scss) + Main Nav links related files - src/components/Nav/index.astro - src/components/Nav/MainNavLinks.tsx - src/components/Nav/NavPanels + +* src/components/Nav/index.astro + +* src/components/Nav/MainNavLinks.tsx + +* src/components/Nav/NavPanels + +MainNavLinks needs a .current From 4d511d2963807736136697d0197e495133250f54 Mon Sep 17 00:00:00 2001 From: kennethyyoung <65055823+kennethyyoung@users.noreply.github.com> Date: Mon, 20 Apr 2026 12:53:10 -0700 Subject: [PATCH 5/7] Update MainNavLinks notes in brainstorming.md Clarified the purpose of .current in MainNavLinks and added a note about underline styles. --- !brainstorming.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/!brainstorming.md b/!brainstorming.md index b73770d5fb..6d9e814f9b 100644 --- a/!brainstorming.md +++ b/!brainstorming.md @@ -10,4 +10,7 @@ Main Nav links related files * src/components/Nav/NavPanels -MainNavLinks needs a .current +MainNavLinks needs a .current (Current active window) + +Underline on hover can be found in styles/global.scss/ + a > &:hover From a953f3be3da923878928a1f941ab7300428532d6 Mon Sep 17 00:00:00 2001 From: Kenneth Young Date: Wed, 22 Apr 2026 20:51:01 -0700 Subject: [PATCH 6/7] feature/nav labels underlined --- src/components/Nav/MainNavLinks.tsx | 8 ++++++-- src/components/Nav/NavPanels.tsx | 3 +++ src/components/Nav/index.astro | 3 +++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/components/Nav/MainNavLinks.tsx b/src/components/Nav/MainNavLinks.tsx index 0e3b628535..f3c38c6ef7 100644 --- a/src/components/Nav/MainNavLinks.tsx +++ b/src/components/Nav/MainNavLinks.tsx @@ -14,6 +14,7 @@ type MainNavLinksProps = { hasJumpTo: boolean; handleToggle: () => void; isOpen: boolean; + currentPath: string; }; export const MainNavLinks = ({ @@ -25,6 +26,7 @@ export const MainNavLinks = ({ handleToggle, isOpen, hasJumpTo, + currentPath, }: MainNavLinksProps) => { if (!links || links?.length <= 0) return null; @@ -74,8 +76,10 @@ export const MainNavLinks = ({ {renderLogo()} diff --git a/src/components/Nav/NavPanels.tsx b/src/components/Nav/NavPanels.tsx index 05359f44e9..9be90bd097 100644 --- a/src/components/Nav/NavPanels.tsx +++ b/src/components/Nav/NavPanels.tsx @@ -14,6 +14,7 @@ interface NavPanelsProps { jumpToLabel: string; isHomepage: boolean; jumpToState: JumpToState | null; + currentPath: string; } /** @@ -30,6 +31,7 @@ export const NavPanels = (props: NavPanelsProps) => { mobileMenuLabel, jumpToLabel, jumpToState, + currentPath, } = props; const [isOpen, setIsOpen] = useState({ main: false, jump: false }); @@ -90,6 +92,7 @@ export const NavPanels = (props: NavPanelsProps) => { hasJumpTo={jumpToState !== null} isOpen={isOpen.main} handleToggle={handleMainNavToggle} + currentPath={currentPath} /> pathMinusLocale.startsWith(link.url))?.url ?? ""; + const editorButtonLabel = t("Start Coding"); const donateButtonLabel = t("Donate"); const mobileMenuLabel = t("Menu"); @@ -37,6 +39,7 @@ const jumpToLabel = t("Jump To"); mobileMenuLabel={mobileMenuLabel as string} jumpToLabel={jumpToLabel as string} jumpToState={jumpToState} + currentPath={currentPath} client:load /> From 43f3923148d8675d36f3c90ae4f314dc0242e99c Mon Sep 17 00:00:00 2001 From: kennethyyoung <65055823+kennethyyoung@users.noreply.github.com> Date: Mon, 27 Apr 2026 09:52:45 -0700 Subject: [PATCH 7/7] Delete !brainstorming.md --- !brainstorming.md | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 !brainstorming.md diff --git a/!brainstorming.md b/!brainstorming.md deleted file mode 100644 index 6d9e814f9b..0000000000 --- a/!brainstorming.md +++ /dev/null @@ -1,16 +0,0 @@ -Underline logic for subsection links (eg. Input and Button) located in src/components/Nav/JumpToLinks.tsx - -CSS in the same folder (styles.modules.scss) - -Main Nav links related files - -* src/components/Nav/index.astro - -* src/components/Nav/MainNavLinks.tsx - -* src/components/Nav/NavPanels - -MainNavLinks needs a .current (Current active window) - -Underline on hover can be found in styles/global.scss/ - a > &:hover