pdd update --output crashes with NameError when code file is in subdirectory

[Serhan-Asad]

Description

pdd update <code_file> --output <path> crashes with NameError when the code file is in a subdirectory.

Reproduction

mkdir -p /tmp/pdd-test/backend/src
echo "def hello(): return 'world'" > /tmp/pdd-test/backend/src/module.py
cd /tmp/pdd-test && git init && git add -A && git commit -m "init"
pdd update backend/src/module.py --output /tmp/output/

Actual output

Error: cannot access local variable 'context_config' where it is not associated with a value

Root cause

In pdd/update_main.py, line 75 defines context_config inside the else branch (when --output is NOT provided). But line 91 uses context_config.get("generate_output_path", "") unconditionally — including when --output IS provided, causing a NameError.

# Line 70-80
if output_dir:
    base_prompts_dir = os.path.abspath(output_dir)  # context_config never set
else:
    context_name, context_config = detect_context_for_file(...)  # only defined here

# Line 91 — reached regardless
code_root = context_config.get("generate_output_path", "")  # NameError if --output was used

Only triggers when the code file is in a subdirectory (so rel_dir != "." at line 85).

Suggested fix

Default context_config = {} before the if/else branch so .get() returns the fallback value.

[Serhan-Asad]

Step 1: Duplicate Check

Status: No duplicates found

Search Performed

• Searched for: "update NameError", "update --output crash", "context_config", "update_main"
• Issues reviewed: ~25 (open and closed)

Findings

No existing issues describe this specific bug (NameError on context_config when using pdd update --output with a subdirectory code file). The closest related issues (#131 - output path construction, #191 - update failures) address different root causes.

This is a new issue. The bug report is well-documented with clear reproduction steps, root cause analysis, and a suggested fix.

---

Proceeding to Step 2: Documentation Check

[Serhan-Asad]

Step 2: Documentation Check

Status: Confirmed Bug

Documentation Reviewed

• CLAUDE.md - pdd update command reference documents --output PATH as a valid option
• pdd/update_main.py:60-100 - Source code confirms the issue

Findings

The --output flag is a documented, supported option for pdd update. The NameError on context_config at line 91 is a clear code defect: the variable is only assigned inside the else branch (line 75, when --output is NOT provided) but referenced unconditionally at line 91 when the code file is in a subdirectory.

This is not a usage error or feature request — the user is invoking the command exactly as documented.

---

Proceeding to Step 3: Triage

[Serhan-Asad]

Step 3: Triage

Status: Proceed

Summary

The issue provides everything needed for reproduction:

• Expected behavior: pdd update backend/src/module.py --output /tmp/output/ should generate a prompt file at the specified output path
• Actual behavior: Crashes with NameError: cannot access local variable 'context_config'
• Reproduction steps: Clearly provided (4 commands)
• Code location: pdd/update_main.py, lines 70-91 — context_config defined only in else branch but used unconditionally
• Trigger condition: --output flag + code file in a subdirectory

Root cause is already identified and verified by Step 2. Straightforward to reproduce.

---

Proceeding to Step 4: Reproduction

[Serhan-Asad]

Step 4: Reproduction

Status: Reproduced

Environment

• macOS Darwin 24.3.0
• Python 3.x with pdd installed from source
• pdd v0.0.144

Steps Taken

1. Created test directory: mkdir -p /tmp/pdd-test/backend/src
2. Created code file: echo "def hello(): return 'world'" > /tmp/pdd-test/backend/src/module.py
3. Initialized git repo: cd /tmp/pdd-test && git init && git add -A && git commit -m "init"
4. Ran: pdd update backend/src/module.py --output /tmp/output/

Observed Behavior

Regeneration mode: Creating or overwriting prompt from code file.
Error: cannot access local variable 'context_config' where it is not associated
with a value
Error during 'update' command:
  An unexpected error occurred: cannot unpack non-iterable NoneType object

Matches the reported error exactly. The NameError occurs at update_main.py:91 where context_config.get("generate_output_path", "") is called, but context_config was only defined in the else branch (line 75) and the --output flag takes the if branch (line 70-72).

Affected Files

• pdd/update_main.py:91 - context_config used outside scope where it was defined
• pdd/update_main.py:70-80 - context_config only assigned in else branch

Notes

• Reproduces reliably when code file is in a subdirectory (so rel_dir != "." at line 85)
• If code file is in repo root, the bug is not triggered because rel_dir == "." skips the problematic code path
• The suggested fix of defaulting context_config = {} before the if/else is correct

---

Proceeding to Step 5: Root Cause Analysis

[Serhan-Asad]

Step 5: Root Cause Analysis

Root Cause Identified: Yes

Summary

Commit 666cb16a9 (PR #263, "Fix #254: Preserve subdirectory structure in pdd update") added code at line 91 that references context_config unconditionally, but context_config is only defined in the else branch at line 75 (when --output is NOT provided). When --output IS provided and the code file is in a subdirectory (rel_dir != "."), execution reaches line 91 and raises NameError.

Technical Details

• Location: pdd/update_main.py:91
• Problematic Code:

# Line 70-72: output_dir branch — context_config never defined
if output_dir:
    base_prompts_dir = os.path.abspath(output_dir)
else:
    # Line 75: context_config only defined here
    context_name, context_config = detect_context_for_file(...)

# Line 91: unconditional use — NameError when output_dir is set
code_root = context_config.get("generate_output_path", "")

• Why it fails: The if output_dir branch at line 70 never assigns context_config. When the code file is in a subdirectory, rel_dir != "." so execution enters the else at line 87 and hits line 91 which references the undefined variable.

Repository History

• Introducing commit: 666cb16a9 by Serhan (2026-01-07) — PR Fix #254: Preserve subdirectory structure in pdd update #263 "Fix pdd update (single file mode) incorrectly places output file #254: Preserve subdirectory structure in pdd update"
• Original structure: PR Fix #254: Preserve subdirectory structure in pdd update #263 added the rel_dir logic (lines 82-97) to preserve subdirectory structure, but didn't account for context_config being undefined in the --output branch
• Context setup: context_config was introduced in 76829e779 by Greg Tanaka (2025-12-27) for .pddrc context awareness

Experiments Performed

1. Traced code path: with --output set and code file in subdirectory, execution goes line 70→72→84→87→91 — context_config never assigned
2. Confirmed rel_dir == "." short-circuits at line 85-86, which is why files in the repo root work fine

Fix Location

• File to modify: pdd/update_main.py
• Why this location: This is both where the symptom appears and the true root cause — the variable scope is wrong
• Existing pattern: Line 76 already uses context_config.get("prompts_dir", "prompts") with a fallback default — same .get() pattern with default works
• Fix approach: Initialize context_config = {} before the if/else block (e.g., at line 69). This way, when --output is provided, context_config.get("generate_output_path", "") returns "" and the code-root stripping is safely skipped — which is correct behavior since the user explicitly specified the output path.

---

Proceeding to Step 5.5: Prompt Classification

[Serhan-Asad]

Step 5.5: Prompt Classification

Classification: Code Bug

DEFECT_TYPE: code

Analysis

This is a straightforward code bug — an uninitialized variable. The context_config variable is only assigned in the else branch (line 75) but referenced unconditionally at line 91 when the code file is in a subdirectory.

Evidence

• Prompt specifies: pdd update <code_file> --output <path> should work with code files in subdirectories
• Code implements: context_config is only defined when --output is NOT provided, causing a NameError when --output IS provided and the file is in a subdirectory
• User expects: The command should work without crashing — consistent with the prompt specification

Conclusion

The code does not correctly implement the intended behavior. The variable context_config needs a default value (e.g., context_config = {}) before the if/else block. Proceeding with test generation.

---

Proceeding to Step 6: Test Plan

[Serhan-Asad]

Step 6: Test Plan

Existing Test Coverage

• Test file: tests/test_update_main.py
• Current coverage: Tests cover manual 3-file mode, git mode, repo mode, regeneration mode, agentic update, and .pddrc context-aware prompts_dir. Also tests subdirectory structure preservation (issue pdd update (single file mode) incorrectly places output file #254).
• Gap: No test covers resolve_prompt_code_pair() with --output when the code file is in a subdirectory (the exact path that triggers context_config being undefined at line 91).

Proposed Tests

Test 1: test_resolve_prompt_code_pair_with_output_dir_and_subdirectory

• Input: resolve_prompt_code_pair("backend/src/module.py", output_dir="/tmp/output/") where the code file is in a subdirectory relative to repo root (so rel_dir != ".")
• Expected: Returns a valid (prompt_path, code_path) tuple without error, prompt placed under output_dir preserving subdirectory structure
• Actual (before fix): NameError: cannot access local variable 'context_config' where it is not associated with a value

Test 2: test_resolve_prompt_code_pair_with_output_dir_root_level_file

• Input: resolve_prompt_code_pair("module.py", output_dir="/tmp/output/") where the code file is at repo root (so rel_dir == ".")
• Expected: Returns valid tuple, prompt at output_dir/module_python.prompt. This case does NOT trigger the bug (line 91 is skipped when rel_dir == ".") but should still work.

Test 3: test_resolve_prompt_code_pair_without_output_dir_subdirectory

• Input: resolve_prompt_code_pair("backend/src/module.py") (no output_dir)
• Expected: Works as before (uses detect_context_for_file), no regression

Test Location

• File: tests/test_update_main.py (append)
• Framework: pytest
• Function under test: pdd.update_main.resolve_prompt_code_pair

Notes

• Tests need a temporary git repo (tmp_path + git.Repo.init()) since resolve_prompt_code_pair uses git.Repo() to find repo root
• Mock get_language to avoid PDD_PATH dependency
• Test 1 is the primary regression test — it must fail before the fix and pass after
• The existing test test_update_preserves_subdirectory_structure_issue_254 covers a similar path but goes through update_main() without --output, so it doesn't hit this bug

---

Proceeding to Step 7: Generate Test

[Serhan-Asad]

Step 7: Generated Test

Test File

tests/test_update_main.py (appended)

Test Code

def test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file(tmp_path, monkeypatch):
    """
    Regression test for GitHub issue #493.
    resolve_prompt_code_pair() crashes with NameError when --output is provided
    and the code file is in a subdirectory (rel_dir != "."), because context_config
    is only defined in the else branch but used unconditionally at line 91.
    """
    repo_path = tmp_path / "test_repo"
    repo_path.mkdir()
    sub_dir = repo_path / "backend" / "src"
    sub_dir.mkdir(parents=True)
    code_file = sub_dir / "module.py"
    code_file.write_text("def hello(): return 'world'")
    output_dir = tmp_path / "output"
    output_dir.mkdir()
    monkeypatch.chdir(repo_path)
    git.Repo.init(repo_path)

    with patch("pdd.update_main.get_language") as mock_lang:
        mock_lang.return_value = "python"
        prompt_path, code_path = resolve_prompt_code_pair(
            str(code_file), quiet=True, output_dir=str(output_dir)
        )

    assert os.path.exists(prompt_path)
    assert str(output_dir) in prompt_path
    assert prompt_path.endswith("module_python.prompt")

Plus two additional tests: root-level code file with --output (edge case) and subdirectory without --output (no-regression).

What This Test Verifies

The primary test triggers the exact UnboundLocalError from issue #493 by calling resolve_prompt_code_pair() with output_dir set and a code file in a subdirectory (backend/src/module.py). This causes rel_dir != "." at line 85, reaching line 91 where context_config.get() is called — but context_config was never assigned because the output_dir branch (line 70-72) skips the assignment.

Running the Test

pytest tests/test_update_main.py::test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file -x

Test Result (on buggy code)

FAILED - UnboundLocalError: cannot access local variable 'context_config' where it is not associated with a value

---

Proceeding to Step 8: Verification

[Serhan-Asad]

Step 8: Verification Complete

Test Execution

FAILED tests/test_update_main.py::test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file
  - UnboundLocalError: cannot access local variable 'context_config' where it is not associated with a value
  - Location: pdd/update_main.py:91
  - 1 failed, 13 passed in 3.80s

Verification Status

PASS: Test correctly detects the bug

The test triggers the exact UnboundLocalError at update_main.py:91 as described in the issue.

Summary

Step	Result
Duplicate Check	Not a duplicate
Documentation	Bug confirmed
Triage	Proceed
Reproduction	Reproduced
Root Cause	Identified
Prompt Classification	Code Bug
Test Plan	Created
Test Generation	Complete
Verification	PASS

Bug Details

• Location: pdd/update_main.py:91
• Root Cause: context_config is only defined in the else branch (line 75) but used unconditionally at line 91 when the code file is in a subdirectory
• Test File: tests/test_update_main.py

Next Steps

1. Fix the bug: initialize context_config = {} before the if/else block
2. Run the test to confirm the fix
3. Run full test suite to check for regressions
4. Submit PR with fix and test

---

Proceeding to Step 9: E2E Tests

[Serhan-Asad]

Step 9: E2E Test

Environment Discovery

• Repository language: Python
• Test framework: pytest
• Existing E2E tests found: Yes - 20+ files matching tests/test_e2e_issue_*.py
• Test configuration: pytest.ini
• Fixtures/helpers used: tmp_path, monkeypatch (pytest builtins)
• Environment variables required: None (LLM calls mocked)
• Auth/credentials: N/A

E2E Test File

tests/test_e2e_issue_493_update_output_subdir.py

Test Type

CLI (exercises update_main() end-to-end as invoked by pdd update)

What This Test Verifies

When a user runs pdd update backend/src/module.py --output /tmp/output/, the command should succeed and generate a prompt file in the output directory. Currently it crashes with UnboundLocalError because context_config is only defined when --output is NOT provided.

Test Code

"""
E2E Test for Issue #493: pdd update --output crashes with NameError when
code file is in a subdirectory.
"""

import os
import pytest
import git
import click
from pathlib import Path
from unittest.mock import patch

from pdd.update_main import update_main


def test_e2e_update_output_flag_with_subdirectory_code_file(tmp_path, monkeypatch):
    repo_path = tmp_path / "pdd-test"
    repo_path.mkdir()
    sub_dir = repo_path / "backend" / "src"
    sub_dir.mkdir(parents=True)
    code_file = sub_dir / "module.py"
    code_file.write_text("def hello(): return 'world'")

    output_dir = tmp_path / "output"
    output_dir.mkdir()

    repo = git.Repo.init(repo_path)
    repo.index.add([str(code_file)])
    repo.index.commit("init")

    monkeypatch.chdir(repo_path)

    ctx = click.Context(click.Command("update"))
    ctx.obj = {
        "strength": 0.5,
        "temperature": 0.0,
        "verbose": False,
        "quiet": True,
    }

    with patch("pdd.update_main.update_prompt") as mock_up, \
         patch("pdd.update_main.get_available_agents", return_value=[]), \
         patch("pdd.update_main.get_language", return_value="python"):

        mock_up.return_value = ("generated prompt content", 0.01, "mock-model")

        result = update_main(
            ctx=ctx,
            input_prompt_file=None,
            modified_code_file=str(code_file),
            input_code_file=None,
            output=str(output_dir),
            use_git=False,
        )

    assert result is not None, "update_main returned None, indicating a crash or error"
    assert result[0] == "generated prompt content"

    prompt_files = list(output_dir.rglob("*_python.prompt"))
    assert len(prompt_files) >= 1, f"No prompt file created in {output_dir}"

Test Execution Result

FAILED tests/test_e2e_issue_493_update_output_subdir.py::test_e2e_update_output_flag_with_subdirectory_code_file
AssertionError: update_main returned None, indicating a crash or error
assert None is not None

The test correctly fails because update_main() catches the UnboundLocalError internally and returns None. Once the fix (context_config = {} before the if/else block) is applied, this test will pass.

E2E Test Status

PASS: E2E test correctly detects the bug

---

Proceeding to Step 10: Create Draft PR

[Serhan-Asad]

Step 10: Draft PR Created

Pull Request

PR #496: Add failing tests for #493: update --output subdirectory crash

Branch

fix/issue-493

What's Included

• Failing unit test at tests/test_update_main.py
• Failing E2E test at tests/test_e2e_issue_493_update_output_subdir.py
• Commits: 1

Next Steps for Maintainers

1. Review the failing tests to understand the expected behavior
2. Implement the fix at the identified location (context_config = {} before the if/else block)
3. Verify both unit and E2E tests pass with your fix
4. Run full test suite to check for regressions
5. Mark the PR as ready for review

PDD Fix Command

To auto-fix this bug using PDD:

pdd fix https://github.com/promptdriven/pdd/issues/493

Tip: Use --protect-tests if the tests are known to be correct, or --max-cycles N to limit fix attempts.

---

Investigation complete. A draft PR with failing tests has been created and linked to this issue.

[Serhan-Asad]

Step 1: Unit Test Execution (Cycle 1)

Status: All Tests Pass

Unit Tests Identified

• tests/test_update_main.py::test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file
• tests/test_update_main.py::test_resolve_prompt_code_pair_output_dir_with_root_level_code_file
• tests/test_update_main.py::test_resolve_prompt_code_pair_no_output_dir_subdirectory_still_works

Initial Test Results

• Passed: 2
• Failed: 1 (test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file — UnboundLocalError: cannot access local variable 'context_config')

Fix Applied

Added context_config = {} before the if output_dir branch at pdd/update_main.py:70, so context_config.get() at line 91 returns the fallback default when --output is provided. No pdd fix needed — fix was a single-line initialization.

Final Test Results

• Passed: 3
• Failed: 0

---

Proceeding to Step 2: E2E Test Check

[Serhan-Asad]

Step 2: E2E Test Check (Cycle 1)

Status: ALL_TESTS_PASS

E2E Tests Run

• tests/test_e2e_issue_493_update_output_subdir.py::test_e2e_update_output_flag_with_subdirectory_code_file ✓
• tests/test_update_main.py::test_resolve_prompt_code_pair_output_dir_with_subdirectory_code_file ✓

Summary

All 2 e2e/unit tests pass. Bug fix complete! The context_config = {} initialization before the if output_dir branch resolves the UnboundLocalError.

---

Workflow complete - all tests passing