Stop making reroute optional

It's a pulpcore feature since 3.18. All plugins should do that by now.

Author: mdellweg

plugin-template

@@ -145,7 +145,6 @@ DEFAULT_SETTINGS = {
     "test_gcp": False,
     "test_lowerbounds": True,
     "test_performance": False,
-    "test_reroute": True,
     "test_s3": False,
     "use_issue_template": True,
 }

templates/github/.github/workflows/scripts/before_install.sh.j2

@@ -45,11 +45,7 @@ if [[ "$TEST" = "lowerbounds" ]]; then
   python3 .ci/scripts/calc_constraints.py {% if setup_py -%} requirements.txt {% else -%} pyproject.toml {% endif -%} > lowerbounds_constraints.txt
 fi
 
-{%- if test_reroute %}
 export PULP_API_ROOT=$(test "${TEST}" = "s3" && echo "/rerouted/djnd/" || echo "{{ api_root }}")
-{%- else %}
-export PULP_API_ROOT="{{ api_root }}"
-{%- endif %}
 
 echo "PULP_API_ROOT=${PULP_API_ROOT}" >> "$GITHUB_ENV"