(CONT-801) Autocorrect safe group 1

Author: LukasAud

.rubocop_todo.yml

@@ -6,45 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith, Severity.
-# SupportedStylesAlignWith: start_of_line, begin
-Layout/BeginEndAlignment:
-  Exclude:
-    - 'lib/puppet/parser/functions/any2bool.rb'
-
-# Offense count: 33
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLinesAroundArguments:
-  Exclude:
-    - 'spec/unit/puppet/provider/file_line/ruby_spec_use_cases.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Exclude:
-    - 'spec/functions/get_module_path_spec.rb'
-
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/HashAlignment:
-  Exclude:
-    - 'lib/puppet/parser/functions/pw_hash.rb'
-    - 'lib/puppet/parser/functions/str2saltedpbkdf2.rb'
-    - 'spec/functions/str2saltedpbkdf2_spec.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Layout/HeredocIndentation:

lib/puppet/functions/parsehocon.rb

@@ -25,6 +25,7 @@ def parsehocon(hocon_string, default = :no_default_provided)
     rescue Hocon::ConfigError::ConfigParseError => err
       Puppet.debug("Parsing hocon failed with error: #{err.message}")
       raise err if default == :no_default_provided
+
       default
     end
   end

lib/puppet/functions/parsepson.rb

@@ -24,6 +24,7 @@ def parsepson(pson_string, default = :no_default_provided)
   rescue StandardError => err
     Puppet.debug("Parsing PSON failed with error: #{err.message}")
     raise err if default == :no_default_provided
+
     default
   end
 end

lib/puppet/parser/functions/any2array.rb

@@ -43,6 +43,7 @@ module Puppet::Parser::Functions
     return arguments unless arguments.length == 1
     return arguments[0] if arguments[0].is_a?(Array)
     return [] if arguments == ['']
+
     if arguments[0].is_a?(Hash)
       result = []
       arguments[0].each do |key, value|

lib/puppet/parser/functions/any2bool.rb

@@ -40,17 +40,18 @@ module Puppet::Parser::Functions
     end
 
     valid_float = begin
-                    !!Float(arg) # rubocop:disable Style/DoubleNegation : Could not find a better way to check if a boolean
-                  rescue
-                    false
-                  end
+      !!Float(arg) # rubocop:disable Style/DoubleNegation : Could not find a better way to check if a boolean
+    rescue
+      false
+    end
 
     if arg.is_a?(Numeric)
       return function_num2bool([arguments[0]])
     end
 
     if arg.is_a?(String)
       return function_num2bool([arguments[0]]) if valid_float
+
       return function_str2bool([arguments[0]])
     end
 

lib/puppet/parser/functions/basename.rb

@@ -18,6 +18,7 @@ module Puppet::Parser::Functions
     rv = File.basename(arguments[0]) if arguments.size == 1
     if arguments.size == 2
       raise(Puppet::ParseError, 'basename(): Requires string as second argument') unless arguments[1].is_a?(String)
+
       rv = File.basename(arguments[0], arguments[1])
     end
 

lib/puppet/parser/functions/defined_with_params.rb

@@ -26,6 +26,7 @@
 ) do |vals|
   reference, params = vals
   raise(ArgumentError, 'Must specify a reference') unless reference
+
   if !params || params == ''
     params = {}
   end

lib/puppet/parser/functions/delete_undef_values.rb

@@ -31,6 +31,7 @@ module Puppet::Parser::Functions
     unless args[0].is_a?(Array) || args[0].is_a?(Hash)
       raise(Puppet::ParseError, "delete_undef_values(): expected an array or hash, got #{args[0]} type  #{args[0].class} ")
     end
+
     result = args[0].dup
     if result.is_a?(Hash)
       result.delete_if { |_, val| val.equal?(:undef) || val.nil? }

lib/puppet/parser/functions/delete_values.rb

@@ -29,6 +29,7 @@ module Puppet::Parser::Functions
     unless hash.is_a?(Hash)
       raise(TypeError, "delete_values(): First argument must be a Hash. Given an argument of class #{hash.class}.")
     end
+
     hash.dup.delete_if { |_key, val| item == val }
   end
 end

lib/puppet/parser/functions/ensure_resource.rb

@@ -35,6 +35,7 @@
   type, title, params = vals
   raise(ArgumentError, 'Must specify a type') unless type
   raise(ArgumentError, 'Must specify a title') unless title
+
   params ||= {}
 
   items = [title].flatten