Addressing legacy facts

Author: LukasAud

lib/puppet/functions/os_version_gte.rb

@@ -21,7 +21,7 @@
 
   def os_version_gte(os, version)
     facts = closure_scope['facts']
-    (facts['operatingsystem'] == os &&
-     Puppet::Util::Package.versioncmp(facts['operatingsystemmajrelease'], version) >= 0)
+    (facts['os']['name'] == os &&
+     Puppet::Util::Package.versioncmp(facts['os']['release']['major'], version) >= 0)
   end
 end

spec/functions/os_version_gte_spec.rb

@@ -6,8 +6,10 @@
   context 'on Debian 9' do
     let(:facts) do
       {
-        operatingsystem: 'Debian',
-        operatingsystemmajrelease: '9',
+        os: {
+          name: 'Debian',
+          release: { major: '9' },
+        }
       }
     end
 
@@ -22,8 +24,10 @@
   context 'on Ubuntu 16.04' do
     let(:facts) do
       {
-        operatingsystem: 'Ubuntu',
-        operatingsystemmajrelease: '16.04',
+        os: {
+          name: 'Ubuntu',
+          release: { major: '16.04' },
+        }
       }
     end
 
@@ -39,8 +43,10 @@
   context 'with invalid params' do
     let(:facts) do
       {
-        operatingsystem: 'Ubuntu',
-        operatingsystemmajrelease: '16.04',
+        os: {
+          name: 'Ubuntu',
+          release: { major: '16.04' },
+        }
       }
     end