Skip to content

Conversation

@Pierre-Sassoulas
Copy link
Member

Follow-up to #2715, there was a lot to cherry-pick to be able to upgrade setuptools cleanly.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Apr 9, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.10 milestone Apr 9, 2025
@Pierre-Sassoulas Pierre-Sassoulas requested a review from cdce8p April 9, 2025 21:30
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (maintenance/3.3.x@4a10a8b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             maintenance/3.3.x    #2720   +/-   ##
====================================================
  Coverage                     ?   93.02%           
====================================================
  Files                        ?       93           
  Lines                        ?    11076           
  Branches                     ?        0           
====================================================
  Hits                         ?    10304           
  Misses                       ?      772           
  Partials                     ?        0           
Flag Coverage Δ
linux 92.89% <100.00%> (?)
pypy 93.02% <100.00%> (?)
windows 93.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_typing.py 87.42% <ø> (ø)
astroid/context.py 97.43% <100.00%> (ø)
astroid/decorators.py 74.46% <ø> (ø)
astroid/helpers.py 95.45% <100.00%> (ø)
astroid/nodes/__init__.py 100.00% <ø> (ø)
astroid/nodes/_base_nodes.py 94.25% <ø> (ø)
astroid/nodes/as_string.py 96.79% <ø> (ø)
astroid/nodes/scoped_nodes/__init__.py 100.00% <ø> (ø)
astroid/nodes/scoped_nodes/scoped_nodes.py 92.84% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdce8p cdce8p force-pushed the upgrading-setuptools branch from f9f4f12 to 492c91f Compare April 10, 2025 12:26
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked one more PR to remove the wheel build-dependency.

@cdce8p cdce8p changed the title Cheey-pick of the setuptools upgrade Cherry-pick of the setuptools upgrade Apr 10, 2025
@Pierre-Sassoulas Pierre-Sassoulas merged commit e29d726 into maintenance/3.3.x Apr 10, 2025
18 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrading-setuptools branch April 10, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining astroid or the dev workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants