-
Notifications
You must be signed in to change notification settings - Fork 124
Remove dependency on Python's built-in cmd module #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The cmd2.Cmd class no longer inhertis from cmd.Cmd
|
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 21 21
Lines 4933 4945 +12
=======================================
+ Hits 4881 4893 +12
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🤖 I'm sorry @tleonhardt, but I was unable to process your request. Please see the logs for more details. |
|
It's complaining about code coverage and the reason I think is we aren't covering the line for the case where |
The
cmd2.Cmdclass no longer inherits fromcmd.Cmdand thecmd2module no longer depends on Python's built-incmdmodule.To make this happen we had to do the following:
cmd2.Cmd.__init__and several extra initializations within itcompletedefaultandcompletenamesmethodsmypywarnings