Skip to content

Commit 07bb69f

Browse files
committed
Fix test_snippets_completion to not depend on typeshed overload ordering
jedi 0.20.0 bundles a newer typeshed that adds a no-arg overload for defaultdict.__init__ as the first overload, causing format_snippet to hit the zero-params branch and produce "defaultdict()" instead of "defaultdict($0)". Replace defaultdict with a locally-defined function to make the test stable across typeshed updates.
1 parent bc1095f commit 07bb69f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test/plugins/test_completion.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ def test_matplotlib_completions(config, workspace) -> None:
322322

323323

324324
def test_snippets_completion(config, workspace) -> None:
325-
doc_snippets = "from collections import defaultdict \na=defaultdict"
325+
doc_snippets = "from collections import defaultdict \ndef foo(a): pass\nfoo"
326326
com_position = {"line": 0, "character": 35}
327327
doc = Document(DOC_URI, workspace, doc_snippets)
328328
config.capabilities["textDocument"] = {
@@ -332,9 +332,9 @@ def test_snippets_completion(config, workspace) -> None:
332332
completions = pylsp_jedi_completions(config, doc, com_position)
333333
assert completions[0]["insertText"] == "defaultdict"
334334

335-
com_position = {"line": 1, "character": len(doc_snippets)}
335+
com_position = {"line": 2, "character": 3}
336336
completions = pylsp_jedi_completions(config, doc, com_position)
337-
assert completions[0]["insertText"] == "defaultdict($0)"
337+
assert completions[0]["insertText"] == "foo($0)"
338338
assert completions[0]["insertTextFormat"] == lsp.InsertTextFormat.Snippet
339339

340340

0 commit comments

Comments
 (0)