Hey,
I wondering why backend.strategy.request_data(merge=False) for do_auth call?
|
def do_auth(backend, redirect_name="next"): |
|
# Save any defined next value into session |
|
data = backend.strategy.request_data(merge=False) |
For example real world applications might use forms POST requests and also in form action might supply query parameters and in this case merge=False for Django strategy will only take POST variables thus unintentionally breaking redirect part or other stages of authentication
<form action="login/facebook?next=/profile">
{% csrf_token %}
<button>Login</button>
</form>
Should there be a configuration option to merge POST and GET by default?
Thanks.
Hey,
I wondering why
backend.strategy.request_data(merge=False)fordo_authcall?social-core/social_core/actions.py
Lines 12 to 14 in 9995648
For example real world applications might use forms
POSTrequests and also in form action might supply query parameters and in this casemerge=Falsefor Django strategy will only takePOSTvariables thus unintentionally breaking redirect part or other stages of authenticationShould there be a configuration option to merge
POSTandGETby default?Thanks.