Skip to content

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Dec 5, 2025

@webknjaz both issues you pointed out

I'm pretty sure this should fix both reasons for failing CI on main.


I'm also seeing this in the logs:

  =========== 857 passed, 34 skipped, 3 xfailed in 103.89s (0:01:43) ============
  C:\hostedtoolcache\windows\Python\3.14.1\x64-freethreaded\Lib\site-packages\coverage\inorout.py:521: CoverageWarning: Module tests/ was never imported. (module-not-imported); see https://coverage.readthedocs.io/en/7.12.0/messages.html#warning-module-not-imported
    self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")

but not sure how to address that :/

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (7d87afe) to head (7d9ba6d).

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main        #3365         +/-   ##
====================================================
+ Coverage   97.88392%   100.00000%   +2.11607%     
====================================================
  Files            128          128                 
  Lines          19848        19407        -441     
  Branches        1387         1318         -69     
====================================================
- Hits           19428        19407         -21     
+ Misses           412            0        -412     
+ Partials           8            0          -8     
Files with missing lines Coverage Δ
src/trio/_core/_tests/test_run.py 100.00000% <ø> (+1.96850%) ⬆️
src/trio/_tests/test_exports.py 100.00000% <ø> (+22.18309%) ⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks
Copy link
Contributor Author

A5rocks commented Dec 5, 2025

Windows 3.14t x64 failed in test_run_in_trio_thread_ki (?) weirdly -- it didn't crash, pytest just suddenly exited. I don't think it's reproducible, but leaving this here for future search to find.

@webknjaz
Copy link
Member

webknjaz commented Dec 5, 2025

I'm also seeing this in the logs:\n\n =========== 857 passed, 34 skipped, 3 xfailed in 103.89s (0:01:43) ============\n C:\hostedtoolcache\windows\Python\3.14.1\x64-freethreaded\Lib\site-packages\coverage\inorout.py:521: CoverageWarning: Module tests/ was never imported. (module-not-imported); see https://coverage.readthedocs.io/en/7.12.0/messages.html#warning-module-not-imported\n self.warn(f"Module {pkg} was never imported.", slug="module-not-imported")\nbut not sure how to address that :/

That seems related to the use of source and not source_pkgs like I mentioned in the other PR. Perhaps, I should look into it myself.

@A5rocks A5rocks merged commit d64798f into python-trio:main Dec 5, 2025
81 of 83 checks passed
@A5rocks A5rocks deleted the fix-ci-changes branch December 5, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants