Use reusable Claude Code workflow from test-infra#3788
Conversation
Replace the inline workflow with the centralized reusable workflow. Passes lintrunner install via setup_script input.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3788
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bfb4f63 with merge base f380781 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@claude review for consistency between original and new behaviors |
|
Claude finished @ZainRizvi's task in 3m 17s —— View job Review: Consistency between original and new behaviors
CaveatI was unable to fetch the reusable workflow at Trigger events
The removal of Verdict: Consistent with stated intent. No accidental omission. Permissions
The permissions are identical in content. The new file declares them at workflow level instead of job level. Since the reusable workflow is called with Verdict: Consistent. Access control / security model
The PR description states the reusable workflow uses Verdict: Deliberate change. Worth confirming that all 20 original pilot users have write access to Setup / lintrunner
The Verdict: The lintrunner commands are consistent. Runtime configuration
All of these are now internal to the reusable workflow. The PR description says "Same model, settings, and usage metrics upload" which is the correct intent. Verdict: Cannot independently verify, but the reusable workflow is designed to be the canonical implementation for all pytorch repos, so these should be standardized. Summary of findings
Overall this looks clean and the new file is dramatically simpler. The consistency is maintained for everything the caller can control, and the behavioral details are correctly delegated to the centralized workflow. |
|
Thanks @ZainRizvi |
Summary
Replaces the inline Claude Code workflow with the centralized reusable workflow from
pytorch/test-infra.What changes
author_associationchecks + API-level write access verificationpull_request_review_commenttrigger (security fix, per [Fix] Revert support for pull request review comments in Claude Code review workflow pytorch#176652)setup_scriptinput (preserving the existing setup)What stays the same
pip install lintrunner==0.12.5 && lintrunner init)Depends on pytorch/test-infra#7810 which added the reusable workflow.
Test plan
@claudetriggers correctly after merge