-
-
Notifications
You must be signed in to change notification settings - Fork 440
Expand file tree
/
Copy pathSimplifyEmptyArrayCheckRector.php
More file actions
115 lines (95 loc) · 3.37 KB
/
SimplifyEmptyArrayCheckRector.php
File metadata and controls
115 lines (95 loc) · 3.37 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\BooleanAnd;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\Empty_;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Variable;
use Rector\NodeManipulator\BinaryOpManipulator;
use Rector\Php71\ValueObject\TwoNodeMatch;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\BooleanAnd\SimplifyEmptyArrayCheckRector\SimplifyEmptyArrayCheckRectorTest
*/
final class SimplifyEmptyArrayCheckRector extends AbstractRector
{
public function __construct(
private readonly BinaryOpManipulator $binaryOpManipulator
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Simplify `is_array` and `empty` functions combination into a simple identical check for an empty array',
[new CodeSample('is_array($values) && empty($values)', '$values === []')]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [BooleanAnd::class];
}
/**
* @param BooleanAnd $node
*/
public function refactor(Node $node): ?Node
{
$twoNodeMatch = $this->resolveTwoNodeMatch($node);
if (! $twoNodeMatch instanceof TwoNodeMatch) {
return null;
}
/** @var FuncCall $isArrayExpr */
$isArrayExpr = $twoNodeMatch->getFirstExpr();
$firstArgValue = $isArrayExpr->getArgs()[0]
->value;
/** @var Empty_ $emptyOrNotIdenticalNode */
$emptyOrNotIdenticalNode = $twoNodeMatch->getSecondExpr();
if ($emptyOrNotIdenticalNode->expr instanceof FuncCall && $this->nodeComparator->areNodesEqual(
$emptyOrNotIdenticalNode->expr->getArgs()[0]
->value,
$firstArgValue
)) {
return new Identical($emptyOrNotIdenticalNode->expr, new Array_());
}
if (! $this->nodeComparator->areNodesEqual($emptyOrNotIdenticalNode->expr, $firstArgValue)) {
return null;
}
return new Identical($emptyOrNotIdenticalNode->expr, new Array_());
}
private function resolveTwoNodeMatch(BooleanAnd $booleanAnd): ?TwoNodeMatch
{
return $this->binaryOpManipulator->matchFirstAndSecondConditionNode(
$booleanAnd,
// is_array(...)
function (Node $node): bool {
if (! $node instanceof FuncCall) {
return false;
}
if ($node->isFirstClassCallable()) {
return false;
}
if (! $this->isName($node, 'is_array')) {
return false;
}
if (isset($node->getArgs()[0])) {
return $node->getArgs()[0]->value instanceof Variable;
}
return false;
},
// empty(...)
function (Node $node): bool {
if (! $node instanceof Empty_) {
return false;
}
return $node->expr instanceof Variable;
}
);
}
}