Skip to content

Commit 77aeeb3

Browse files
authored
Remove trait support rom AddParamBasedOnParentClassMethodRector as depends on context; move to Class_ node hooking for efficiency (#7587)
1 parent f1e7df1 commit 77aeeb3

8 files changed

Lines changed: 86 additions & 174 deletions

File tree

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/implements_interface.php.inc

Lines changed: 0 additions & 41 deletions
This file was deleted.

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/implements_interface_flipped.php.inc

Lines changed: 0 additions & 41 deletions
This file was deleted.

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/must_follow_abstract_trait_method.php.inc

Lines changed: 0 additions & 29 deletions
This file was deleted.

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/skip_renamed_non_abstract_method_trait.php.inc renamed to rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/skip_trait.php.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ namespace Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethod
44

55
use Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector\Source\ValuesTrait;
66

7-
trait SkipRenamedNonAbstractMethodTrait {
7+
trait SkipTrait {
88
use ValuesTrait {
99
addValue as addAnyValue;
1010
}

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Fixture/skip_used_in_coalesce.php.inc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ namespace Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethod
44

55
use Rector\Tests\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector\Source\ParentWithParam;
66

7-
class SkipUsedInCoalesce extends ParentWithParam{
7+
final class SkipUsedInCoalesce extends ParentWithParam
8+
{
89
public function execute()
910
{
1011
echo $foo ?? 'test';
1112
}
1213
}
13-
14-
?>

rules-tests/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector/Source/ValuesTraitAbstract.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ public function getNodeTypes(): array
7373
*/
7474
public function refactor(Node $node): ?Node
7575
{
76+
// skip as no comments
77+
if ($node->getComments() === []) {
78+
return null;
79+
}
80+
7681
$phpDocInfo = $this->phpDocInfoFactory->createFromNode($node);
7782
if (! $phpDocInfo instanceof PhpDocInfo) {
7883
return null;

0 commit comments

Comments
 (0)