skip mixed[] on ClassMethodArrayDocblockParamFromLocalCallsRector as no extra value (#7270)

Author: TomasVotruba

rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/skip_mixed_mixed.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector\Fixture;
+
+final class SkipMixedMixed
+{
+    public function go($mixed)
+    {
+        $this->run(['item1', 'item2']);
+
+        $this->run([$mixed, $mixed]);
+    }
+
+    private function run(array $items)
+    {
+    }
+}

rules/Privatization/TypeManipulator/TypeNormalizer.php

@@ -25,7 +25,7 @@ final class TypeNormalizer
      * @deprecated This method is deprecated and will be removed in the next major release.
      * Use @see generalizeConstantTypes() instead.
      */
-    public function generalizeConstantBoolTypes(\PHPStan\Type\Type $type): Type
+    public function generalizeConstantBoolTypes(Type $type): Type
     {
         return $this->generalizeConstantTypes($type);
     }

rules/TypeDeclarationDocblocks/Rector/Class_/AddReturnDocblockDataProviderRector.php

@@ -154,11 +154,9 @@ public function refactor(Node $node): ?Node
             if ($yields !== []) {
                 $yieldType = $this->yieldTypeResolver->resolveFromYieldNodes($yields, $dataProviderClassMethod);
 
-                if ($yieldType instanceof FullyQualifiedGenericObjectType) {
-                    if ($yieldType->getClassName() === 'Generator') {
-                        // most likely, a static iterator is used in data test fixtures
-                        $yieldType = new FullyQualifiedGenericObjectType('Iterator', $yieldType->getTypes());
-                    }
+                if ($yieldType instanceof FullyQualifiedGenericObjectType && $yieldType->getClassName() === 'Generator') {
+                    // most likely, a static iterator is used in data test fixtures
+                    $yieldType = new FullyQualifiedGenericObjectType('Iterator', $yieldType->getTypes());
                 }
 
                 $this->addGeneratedTypeReturnDocblockType($yieldType, $classMethodPhpDocInfo, $dataProviderClassMethod);

rules/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector.php

@@ -7,6 +7,9 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
+use PHPStan\Type\ArrayType;
+use PHPStan\Type\IntegerType;
+use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
@@ -119,6 +122,12 @@ public function refactor(Node $node): ?Node
                 $normalizedResolvedParameterType = $this->typeNormalizer->generalizeConstantTypes(
                     $resolvedParameterType
                 );
+
+                // most likely mixed, skip
+                if ($this->isArrayMixed($normalizedResolvedParameterType)) {
+                    continue;
+                }
+
                 $arrayDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode(
                     $normalizedResolvedParameterType
                 );
@@ -137,4 +146,17 @@ public function refactor(Node $node): ?Node
 
         return $node;
     }
+
+    private function isArrayMixed(Type $type): bool
+    {
+        if (! $type instanceof ArrayType) {
+            return false;
+        }
+
+        if (! $type->getItemType() instanceof MixedType) {
+            return false;
+        }
+
+        return $type->getKeyType() instanceof IntegerType;
+    }
 }