Support Param nodes in makeNonFinal() (#7228)

arshidkv12 · Arshid · web-flow · commit aeab56549796 · 2025-09-08T02:29:25.000+07:00
* Support Param nodes in makeNonFinal()

* Support Param nodes in makeNonFinal()

* Support Param nodes in makeNonFinal()

---------

Co-authored-by: Arshid &lt;arshid@Arshids-MacBook-Air.local&gt;
diff --git a/rules/Privatization/NodeManipulator/VisibilityManipulator.php b/rules/Privatization/NodeManipulator/VisibilityManipulator.php
@@ -58,17 +58,17 @@ public function makeNonAbstract(ClassMethod | Class_ $node): void
     /**
      * @api
      */
-    public function makeFinal(Class_ | ClassMethod | ClassConst $node): void
+    public function makeFinal(Class_ | ClassMethod | Param | ClassConst $node): void
     {
         $this->addVisibilityFlag($node, Visibility::FINAL);
     }
 
     /**
      * @api
      */
-    public function makeNonFinal(Class_ | ClassMethod $node): void
+    public function makeNonFinal(Class_ | ClassMethod | Param $node): void
     {
-        if (! $node->isFinal()) {
+        if (! $this->hasVisibility($node, Visibility::FINAL)) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -58,17 +58,17 @@ public function makeNonAbstract(ClassMethod \| Class_ $node): void`
`58`	`58`	`/**`
`59`	`59`	`* @api`
`60`	`60`	`*/`
`61`		`- public function makeFinal(Class_ \| ClassMethod \| ClassConst $node): void`
	`61`	`+ public function makeFinal(Class_ \| ClassMethod \| Param \| ClassConst $node): void`
`62`	`62`	`{`
`63`	`63`	`$this->addVisibilityFlag($node, Visibility::FINAL);`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/**`
`67`	`67`	`* @api`
`68`	`68`	`*/`
`69`		`- public function makeNonFinal(Class_ \| ClassMethod $node): void`
	`69`	`+ public function makeNonFinal(Class_ \| ClassMethod \| Param $node): void`
`70`	`70`	`{`
`71`		`- if (! $node->isFinal()) {`
	`71`	`+ if (! $this->hasVisibility($node, Visibility::FINAL)) {`
`72`	`72`	`return;`
`73`	`73`	`}`
`74`	`74`