make DeclareStrictTypesRector skip files without namespace, as very risky in files without PSR-4 autodsicovery

Author: TomasVotruba

rules-tests/DeadCode/Rector/ClassMethod/RemoveUselessAssignFromPropertyPromotionRector/Fixture/skip_normal_param.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUselessAssignFromPropertyPromotionRector\Fixture;
+
+class SkipNormalParam
+{
+    private \stdClass $std;
+
+    public function __construct(\stdClass $std)
+    {
+        $this->std = $std;
+    }
+}
+

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/AutoImportDeclareStrictTypesRectorTest.php

@@ -0,0 +1,5 @@
+<?php
+
+function someFunction()
+{
+}

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/skip_without_namespace.php.inc

@@ -34,20 +34,30 @@ public function __construct(
 
     public function getRuleDefinition(): RuleDefinition
     {
-        return new RuleDefinition('Add `declare(strict_types=1)` if missing', [
+        return new RuleDefinition('Add `declare(strict_types=1)` if missing in a namespaced file', [
             new CodeSample(
                 <<<'CODE_SAMPLE'
-function someFunction()
+namespace App;
+
+class SomeClass
 {
+    function someFunction(int $number)
+    {
+    }
 }
 CODE_SAMPLE
 
                 ,
                 <<<'CODE_SAMPLE'
 declare(strict_types=1);
 
-function someFunction()
+namespace App;
+
+class SomeClass
 {
+    function someFunction(int $number)
+    {
+    }
 }
 CODE_SAMPLE
             ),
@@ -79,14 +89,7 @@ public function beforeTraverse(array $nodes): ?array
         $stmt = $rootStmt;
 
         if ($rootStmt instanceof FileWithoutNamespace) {
-            $currentStmt = current($rootStmt->stmts);
-
-            if (! $currentStmt instanceof Stmt) {
-                return null;
-            }
-
-            $nodes = $rootStmt->stmts;
-            $stmt = $currentStmt;
+            return null;
         }
 
         // when first stmt is Declare_, verify if there is strict_types definition already,
@@ -101,12 +104,6 @@ public function beforeTraverse(array $nodes): ?array
         $rectorWithLineChange = new RectorWithLineChange(self::class, $stmt->getStartLine());
         $this->file->addRectorClassWithLine($rectorWithLineChange);
 
-        if ($rootStmt instanceof FileWithoutNamespace) {
-            /** @var Stmt[] $nodes */
-            $rootStmt->stmts = [$strictTypesDeclare, new Nop(), ...$nodes];
-            return [$rootStmt];
-        }
-
         return [$strictTypesDeclare, new Nop(), ...$nodes];
     }
 
@@ -121,7 +118,7 @@ public function getNodeTypes(): array
     /**
      * @param StmtsAwareInterface $node
      */
-    public function refactor(Node $node): ?int
+    public function refactor(Node $node): int
     {
         // workaround, as Rector now only hooks to specific nodes, not arrays
         // avoid traversing, as we already handled in beforeTraverse()