[TypeDeclaration] Skip already has @ return list<> docblock on AddReturnArrayDocblockBasedOnArrayMapRector (#7315)

* [TypeDeclaration] Skip already has @ return docblock on AddReturnArrayDocblockBasedOnArrayMapRector

* Fix

Author: samsonasik

rules-tests/TypeDeclaration/Rector/ClassMethod/AddReturnArrayDocblockBasedOnArrayMapRector/Fixture/skip_already_has_return_doc.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector\Fixture;
+
+use stdClass;
+
+final class SkipAlreadyHasReturnDoc
+{
+    /**
+     * @return list<stdClass>
+     */
+    public function process(array $items)
+    {
+        return array_map(function ($item): stdClass {
+            return $item;
+        }, $items);
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/AddReturnArrayDocblockBasedOnArrayMapRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PHPStan\Type\ArrayType;
+use PHPStan\Type\IntersectionType;
 use PHPStan\Type\MixedType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
@@ -125,6 +126,11 @@ public function refactor(Node $node): null|Function_|ClassMethod
 
         $functionLikePhpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
+        $returnOriginalType = $functionLikePhpDocInfo->getReturnType();
+        if ($returnOriginalType instanceof IntersectionType && $returnOriginalType->isArray()->yes()) {
+            return null;
+        }
+
         $hasChanged = $this->phpDocTypeChanger->changeReturnType($node, $functionLikePhpDocInfo, $arrayType);
         if ($hasChanged) {
             return $node;

rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForCommonObjectDenominatorRector.php

@@ -9,7 +9,6 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Return_;
-use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\Constant\ConstantArrayType;
@@ -109,10 +108,6 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
-        if ($phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode) {
-            return null;
-        }
-
         $returnType = $phpDocInfo->getReturnType();
 
         if (! $returnType instanceof MixedType || $returnType->isExplicitMixed()) {