Skip to content

Commit f4f9196

Browse files
[php 8.1] skip nullable property without null default in NewInInitializerRector (#7546)
* tidy up similar fixtures to make tests more readble * skip nullable property without null default, as null is always passed from outside to trigger * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <actions@github.com>
1 parent b4e964f commit f4f9196

13 files changed

Lines changed: 55 additions & 171 deletions

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg.php.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
55
use DateTime;
66
use DateTimeZone;
77

8-
class PassNonDynamicArg
8+
final class PassNonDynamicArg
99
{
1010
private DateTime $dateTime;
1111

@@ -25,7 +25,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2525
use DateTime;
2626
use DateTimeZone;
2727

28-
class PassNonDynamicArg
28+
final class PassNonDynamicArg
2929
{
3030
public function __construct(private ?DateTime $dateTime = new DateTime('now', new DateTimeZone('Asia/Jakarta')))
3131
{

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg2.php.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
44

5-
class SomeClass
5+
final class PassNonDynamicArg2
66
{
77
private Logger $logger;
88

@@ -19,7 +19,7 @@ class SomeClass
1919

2020
namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
2121

22-
class SomeClass
22+
final class PassNonDynamicArg2
2323
{
2424
public function __construct(private ?Logger $logger = new NullLogger(['a' => 'b']))
2525
{

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg3.php.inc

Lines changed: 0 additions & 29 deletions
This file was deleted.

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg4.php.inc

Lines changed: 0 additions & 33 deletions
This file was deleted.

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg5.php.inc

Lines changed: 0 additions & 29 deletions
This file was deleted.

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/pass_non_dynamic_arg6.php.inc

Lines changed: 0 additions & 29 deletions
This file was deleted.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?php
2+
3+
namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
4+
5+
use Php81\Rector\ClassMethod\NewInInitializerRector\Source\Logger\DefaultLogger;
6+
use Php81\Rector\ClassMethod\NewInInitializerRector\Source\Logger\NullLogger;
7+
8+
final class SkipIfNoDefaultNull
9+
{
10+
private DefaultLogger $logger;
11+
12+
public function __construct(
13+
?DefaultLogger $logger,
14+
) {
15+
$this->logger = $logger ?? new NullLogger();
16+
}
17+
}

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_no_param_construct.php.inc

Lines changed: 0 additions & 10 deletions
This file was deleted.

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_pass_dynamic_arg.php.inc

Lines changed: 0 additions & 17 deletions
This file was deleted.

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/skip_pass_dynamic_arg4.php.inc

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)