From a5a7bf72814722fab2685327cb3a370433d34944 Mon Sep 17 00:00:00 2001 From: Benjamin Barrera-Altuna Date: Thu, 30 Apr 2026 02:19:55 -0400 Subject: [PATCH 1/2] fix(docs): remove dead breadcrumb docs segment filter --- .../reflex_docs/templates/docpage/docpage.py | 4 ++-- docs/app/tests/test_breadcrumb.py | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 docs/app/tests/test_breadcrumb.py diff --git a/docs/app/reflex_docs/templates/docpage/docpage.py b/docs/app/reflex_docs/templates/docpage/docpage.py index 96dfe4b5d6b..0e4c4746a4d 100644 --- a/docs/app/reflex_docs/templates/docpage/docpage.py +++ b/docs/app/reflex_docs/templates/docpage/docpage.py @@ -607,11 +607,11 @@ def breadcrumb(path: str, nav_sidebar: rx.Component, doc_content: str | None = N docs_sidebar_drawer, ) - # Split the path into segments, removing 'docs' and capitalizing each segment + # Split the path into segments and capitalize each segment. segments = [ segment.capitalize() for segment in path.split("/") - if segment and segment != "docs" + if segment ] # Initialize an empty list to store the breadcrumbs and their separators diff --git a/docs/app/tests/test_breadcrumb.py b/docs/app/tests/test_breadcrumb.py new file mode 100644 index 00000000000..f008c2b5edd --- /dev/null +++ b/docs/app/tests/test_breadcrumb.py @@ -0,0 +1,19 @@ +"""Tests for docs breadcrumb rendering.""" + +import sys +from pathlib import Path + +import reflex as rx + +sys.path.append(str(Path(__file__).resolve().parent.parent)) + + +def test_breadcrumb_keeps_docs_segment_when_present_in_path(): + """Breadcrumb segment mapping should not special-case the docs segment.""" + from reflex_docs.templates.docpage.docpage import breadcrumb + + rendered = str(breadcrumb("/docs/ai/integrations/", rx.box())) + + assert "Docs" in rendered + assert "Ai" in rendered + assert "Integrations" in rendered From 50f03791714c17384d793668a9c930d6f4d601f6 Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Fri, 1 May 2026 00:14:25 -0700 Subject: [PATCH 2/2] pre-commit --- docs/app/reflex_docs/templates/docpage/docpage.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/docs/app/reflex_docs/templates/docpage/docpage.py b/docs/app/reflex_docs/templates/docpage/docpage.py index 0e4c4746a4d..b797b8045c0 100644 --- a/docs/app/reflex_docs/templates/docpage/docpage.py +++ b/docs/app/reflex_docs/templates/docpage/docpage.py @@ -608,11 +608,7 @@ def breadcrumb(path: str, nav_sidebar: rx.Component, doc_content: str | None = N ) # Split the path into segments and capitalize each segment. - segments = [ - segment.capitalize() - for segment in path.split("/") - if segment - ] + segments = [segment.capitalize() for segment in path.split("/") if segment] # Initialize an empty list to store the breadcrumbs and their separators breadcrumbs = []