Commit f2bd4f8
committed
fix: validate interval bounds in Union before appending
The Union function computes intersection intervals by taking max(start)
and min(end) of two intervals. However, when intervals don't actually
overlap (e.g., [90,95] and [80,88]), this produces invalid intervals
where start > end (e.g., [90,88]).
This causes a panic in TotalWhitespace when it tries to slice with
invalid bounds: `lines[90:88]` -> "slice bounds out of range [90:88]"
The fix validates that start <= end before appending to the result,
which correctly handles non-overlapping intervals by excluding them.
Added test cases for non-overlapping and adjacent intervals.1 parent 02f4237 commit f2bd4f8
2 files changed
Lines changed: 29 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
105 | 108 | | |
106 | 109 | | |
107 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
80 | 102 | | |
81 | 103 | | |
82 | 104 | | |
| |||
0 commit comments