Seed Node not work well with subgraph

[NateScarlet]

1. Put Seed node inside a subgraph
2. Queue this workflow

server will log

[rgthree-comfy][Seed] Got "-1" as passed seed. This shouldn't happen when queueing from the ComfyUI frontend.
[rgthree-comfy][Seed] Server-generated random seed 612978552492545 and saving to workflow.
[rgthree-comfy][Seed] NOTE: Re-queues passing in "{seed}" and server-generated random seed won't be cached.
[rgthree-comfy][Seed] Cannot save server-generated seed to image workflow metadata because node was not found in the provided workflow.

[GreenLandisaLie]

I love this node - I use it on every workflow and I too would like to make it work within a subgraph.

So, to solve this problem, this line: (x for x in extra_pnginfo['workflow']['nodes'] if x['id'] == int(unique_id)), None) (in seed.py) needs to be changed to: (x for x in extra_pnginfo['workflow']['nodes'] if x['id'] == int(str(unique_id).split(":")[-1])), None) because the 'unique_id' of a node that's inside a subgraph is a string with the format: "parent_id:child_id" - at least that's what ChatGPT says and it makes sense I just don't know if the order is like that or the inverse.

Apart from that error, another issue with the node is that it does not expose the ♻️ (Use Last Queued Seed) button as a valid subgraph's widget because of these lines: this.lastSeedButton.disabled = true; . So they need to be removed. It still works as intended even when doing so - so removing them is not a problem.

EDIT: Turns out this alone won't work. The handleApiHijacking(e) function is not designed to handle subgraphs and it relies on a part of the API that does not expose the nodes within a subgraph - at least it doesn't seems so. This whole part needs an overhaul.

EDIT2: Finally got it working though this code is amateurish and needs the hands of a professional.
On top of the changes I mentioned above - in seed.js, after line let outputInputs = (_c = output === null || output === void 0 ? void 0 : output[this.id]) === null || _c === void 0 ? void 0 : _c.inputs; add this logic:

		var containsLastSeedSubgraphWidget = false;
		if (!workflowNode && workflow != null && workflow != void 0 
			&& workflow.definitions != null && workflow.definitions != void 0 
			&& workflow.definitions.subgraphs != null && workflow.definitions.subgraphs != void 0) {
				for (const subgraph of workflow.definitions.subgraphs) {
					if (subgraph.nodes != null && subgraph.nodes != void 0) {
						for (const subnode of subgraph.nodes) {
							if (subnode != null && subnode != void 0 && subnode.type === "Seed (rgthree)" && subnode.id === this.id) {
								workflowNode = subnode;
								const subgraphNode = workflow.nodes.find((n) => n.type === subgraph.id);
								if (subgraphNode.properties != null && subgraphNode.properties != void 0 && subgraphNode.properties.proxyWidgets != null && subgraphNode.properties.proxyWidgets != void 0) {
									for (const subWidgetProperty of subgraphNode.properties.proxyWidgets) {
										if (subWidgetProperty[0] === String(this.id) && subWidgetProperty[1].indexOf('♻️') > -1) {
											containsLastSeedSubgraphWidget = true;
											break;
										}
									}
								}
								break;
							}
						}
					}
					if (workflowNode) break;
				}
		}
		if (!outputInputs && workflow != null && workflow != void 0) {
			for (var output_key in output) {
				if ( String(output_key).endsWith(`:${this.id}`) && output[output_key] != null && output[output_key] != void 0 && output[output_key].class_type === "Seed (rgthree)" ) {
					outputInputs = output[output_key].inputs;
				}
			}
		}

then change this:

        if (seedToUse != this.seedWidget.value) {
            this.lastSeedButton.name = `♻️ ${this.lastSeed}`;
        }
        else {
            this.lastSeedButton.name = LAST_SEED_BUTTON_LABEL;
        }

to this:

		// change name only when the node's last seed widget is NOT being used as a subgraph's widget - because it disconnects if we change it here and I was not able to find a solution for it -.-
		if (!containsLastSeedSubgraphWidget) this.lastSeedButton.name = seedToUse != this.seedWidget.value ? `♻️ ${this.lastSeed}` : LAST_SEED_BUTTON_LABEL;

On a side note, is this intentional or a bug:

    onRemoved() {
        rgthree.addEventListener("comfy-api-queue-prompt-before", this.handleApiHijackingBound);
    }

?? Should it not be removeEventListener instead?

[rgthree]

This should now be fixed in the latest.