feat(analyzer): add error codes VariableNotReplaced and EnvironmentVariableNotReplaced for variables not found/replaced in documentation, tags, and metadata

Author: d-biehl

packages/robot/src/robotcode/robot/diagnostics/errors.py

@@ -6,7 +6,9 @@
 @final
 class Error:
     VARIABLE_NOT_FOUND = "VariableNotFound"
+    VARIABLE_NOT_REPLACED = "VariableNotReplaced"
     ENVIRONMENT_VARIABLE_NOT_FOUND = "EnvironmentVariableNotFound"
+    ENVIRONMENT_VARIABLE_NOT_REPLACED = "EnvironmentVariableNotReplaced"
     KEYWORD_NOT_FOUND = "KeywordNotFound"
     LIBRARY_CONTAINS_NO_KEYWORDS = "LibraryContainsNoKeywords"
     POSSIBLE_CIRCULAR_IMPORT = "PossibleCircularImport"

packages/robot/src/robotcode/robot/diagnostics/namespace_analyzer.py

@@ -480,9 +480,13 @@ def _handle_find_variable_result(
         if var.type == VariableDefinitionType.VARIABLE_NOT_FOUND:
             self._append_diagnostics(
                 range=range_from_token(var_token),
-                message=f"Variable '{var.name}' not found.",
+                message=(
+                    f"Variable '{var.name}' not replaced."
+                    if severity == DiagnosticSeverity.HINT
+                    else f"Variable '{var.name}' not found."
+                ),
                 severity=severity,
-                code=Error.VARIABLE_NOT_FOUND,
+                code=Error.VARIABLE_NOT_REPLACED if severity == DiagnosticSeverity.HINT else Error.VARIABLE_NOT_FOUND,
             )
         else:
             if (
@@ -493,9 +497,17 @@ def _handle_find_variable_result(
                 if os.environ.get(env_name, None) is None:
                     self._append_diagnostics(
                         range=range_from_token(var_token),
-                        message=f"Environment variable '{var.name}' not found.",
+                        message=(
+                            f"Environment variable '{var.name}' not replaced."
+                            if severity == DiagnosticSeverity.HINT
+                            else f"Environment variable '{var.name}' not found."
+                        ),
                         severity=severity,
-                        code=Error.ENVIRONMENT_VARIABLE_NOT_FOUND,
+                        code=(
+                            Error.ENVIRONMENT_VARIABLE_NOT_REPLACED
+                            if severity == DiagnosticSeverity.HINT
+                            else Error.ENVIRONMENT_VARIABLE_NOT_FOUND
+                        ),
                     )
 
             if var.type == VariableDefinitionType.ENVIRONMENT_VARIABLE:

pyproject.toml

@@ -262,6 +262,8 @@ mypy_path = [
   "packages/robot/src",
   "packages/runner/src",
   "packages/analyze/src",
+  "packages/repl/src",
+  "packages/repl_server/src",
 ]
 # allow_untyped_calls = true