Skip to content

HT6#56

Open
mas-student wants to merge 2 commits into
romabelka:masterfrom
mas-student:HT6
Open

HT6#56
mas-student wants to merge 2 commits into
romabelka:masterfrom
mas-student:HT6

Conversation

@mas-student
Copy link
Copy Markdown

No description provided.

Comment thread src/AC/index.js
} No newline at end of file
}

export function loadAllComments() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это зачем?


componentDidMount() {
const { loadAllComments, loaded} = this.props
if (!loaded) loadPageComments()
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Работает?

Copy link
Copy Markdown
Author

@mas-student mas-student Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Работает.
loadAllComments надо убрать.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!loaded) loadPageComments() лишний.
Нужный находится ниже

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И неправильный к тому же. Правильный loadPageComments(no)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

То есть, конечно, конкретно этот кусок кода не работает. Работает в целом. Это ошибка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants