-
Notifications
You must be signed in to change notification settings - Fork 20
HT6 Lazucov Dmitrii #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
palzuncoff
wants to merge
11
commits into
romabelka:master
Choose a base branch
from
palzuncoff:HT5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4664a5a
Create Router
568f6f0
Add AC
78bc103
Add loadedIds to comments
63f9460
Add total niumber to comments
634c84d
Add pagination buttons
4d6937d
Add page button handler
95cee38
Create link for comment page
0f67e99
Add Loader
b148730
Comments page load once
b62cc79
Fix
25eb050
Fix first loading
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import React from 'react' | ||
| import PropTypes from 'prop-types' | ||
| import { connect } from 'react-redux' | ||
| import Comment from '../comment' | ||
| import { commentsByPage, commentsLoading } from '../../selectors' | ||
| import { loadAllcomments } from '../../AC' | ||
| import Loader from '../loader' | ||
|
|
||
| class CommentsPage extends React.Component { | ||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| if (nextProps.page !== this.props.page) { | ||
| const { comments } = this.props | ||
| this.props.loadAllcomments((nextProps.page - 1)*5, nextProps.page) | ||
| } | ||
| } | ||
|
|
||
| render() { | ||
| const { comments, loading } = this.props | ||
| return( | ||
| <div> | ||
| {loading ? <Loader/> : | ||
| <ul> | ||
| { | ||
| comments.map(id => | ||
| <li key = {id} className = "test__comment-list--item"> | ||
| <Comment id = {id}/> | ||
| </li>) | ||
| } | ||
| </ul> | ||
| } | ||
| </div> | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| CommentsPage.propTypes = { | ||
| comments: PropTypes.array, | ||
| loading: PropTypes.bool, | ||
| loadAllcomments: PropTypes.fun | ||
| } | ||
|
|
||
| CommentsPage.defaultProps = { | ||
| comments: [], | ||
| } | ||
|
|
||
| const mapStateToProps = (state, ownProps) => { | ||
| return { | ||
| comments: commentsByPage(state, ownProps), | ||
| loading: commentsLoading(state) | ||
| } | ||
| } | ||
|
|
||
| const mapDispatchToProps = { | ||
| loadAllcomments | ||
| } | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(CommentsPage) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import React from 'react' | ||
| import { NavLink, Route } from 'react-router-dom' | ||
| import PropTypes from 'prop-types' | ||
| import { connect } from 'react-redux' | ||
| import Comment from '../comment' | ||
| import CommentsPage from './CommentsPage' | ||
| import { loadAllcomments } from '../../AC' | ||
| import { allCommentsSelector, totalComments } from '../../selectors' | ||
|
|
||
| class AllComments extends React.Component { | ||
|
|
||
| componentDidMount() { | ||
| this.props.loadAllcomments(0, "1") | ||
| } | ||
|
|
||
| renderButtons = total => { | ||
| const count = new Array(Math.ceil(total / 5)).fill(null) | ||
| return count.map((_, index) => ( | ||
| <NavLink to={`/comments/${index + 1}`} key={`button-page-${index + 1}`} > | ||
| <button>{index + 1}</button> | ||
| </NavLink> | ||
| )) | ||
| } | ||
|
|
||
| render() { | ||
| const { total, match } = this.props | ||
| return( | ||
| <div> | ||
| <Route path = {`${match.path}/:page`} children = {this.getCommentsPage}/> | ||
| {this.renderButtons(total)} | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| getCommentsPage = ({ match }) => { | ||
| if (!match) { | ||
| return <CommentsPage page={"1"} /> | ||
| } | ||
| return <CommentsPage page={match.params.page} /> | ||
| } | ||
| } | ||
|
|
||
| AllComments.propTypes = { | ||
| match: PropTypes.object, | ||
| total: PropTypes.number | ||
| } | ||
|
|
||
| const mapStateToProps = (state, ownProps) => { | ||
| return { | ||
| total: totalComments(state), | ||
| } | ||
| } | ||
|
|
||
| const mapDispatchToProps = { | ||
| loadAllcomments | ||
| } | ||
|
|
||
| export default connect(mapStateToProps, mapDispatchToProps)(AllComments) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему AllComments и почему бы не обойтись только page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Этого объяснить не могу((, не отрефакторил,