From e99312029a4616a6a7be71be5a574246ce45e0c3 Mon Sep 17 00:00:00 2001 From: ipinak Date: Tue, 15 Jul 2025 14:02:00 +0300 Subject: [PATCH 1/2] use fixed length array --- migrate.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migrate.go b/migrate.go index c9cb4a48..2878afd4 100644 --- a/migrate.go +++ b/migrate.go @@ -640,11 +640,11 @@ func (ms MigrationSet) planMigrationCommon(db *sql.DB, dialect string, m Migrati } // Sort migrations that have been run by Id. - var existingMigrations []*Migration - for _, migrationRecord := range migrationRecords { - existingMigrations = append(existingMigrations, &Migration{ + existingMigrations := make([]*Migration, len(migrationRecords)) + for i, migrationRecord := range migrationRecords { + existingMigrations[i] = &Migration{ Id: migrationRecord.Id, - }) + } } sort.Sort(byId(existingMigrations)) From bb2ebe7b93796a84f7e5ec444cb66487f188b995 Mon Sep 17 00:00:00 2001 From: ipinak Date: Wed, 16 Jul 2025 08:37:25 +0300 Subject: [PATCH 2/2] use fixed length array --- migrate.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migrate.go b/migrate.go index 2878afd4..d08e22b4 100644 --- a/migrate.go +++ b/migrate.go @@ -640,11 +640,11 @@ func (ms MigrationSet) planMigrationCommon(db *sql.DB, dialect string, m Migrati } // Sort migrations that have been run by Id. - existingMigrations := make([]*Migration, len(migrationRecords)) - for i, migrationRecord := range migrationRecords { - existingMigrations[i] = &Migration{ + existingMigrations := make([]*Migration, 0, len(migrationRecords)) + for _, migrationRecord := range migrationRecords { + existingMigrations = append(existingMigrations, &Migration{ Id: migrationRecord.Id, - } + }) } sort.Sort(byId(existingMigrations))