Skip to content

Fix wss urls and session_id lost #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neo87cs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix wss urls and session_id lost #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa5d1d
fix: loosing session_id on target
neo87cs Jan 28, 2026
380fe59
fix: wss scheme for ws_url must be managed over SSL
neo87cs Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ferrum/client/web_socket.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def initialize(url, max_receive_size, logger)
uri = URI.parse(@url)
port = uri.port || DEFAULT_PORTS[uri.scheme]

if port == 443
if port == 443 || url.scheme == 'wss'
tcp = TCPSocket.new(uri.host, port)
ssl_context = OpenSSL::SSL::SSLContext.new
@sock = OpenSSL::SSL::SSLSocket.new(tcp, ssl_context)
Expand Down
2 changes: 2 additions & 0 deletions lib/ferrum/context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def add_target(params:, session_id: nil)
new_target = Target.new(@client, session_id, params)
# `put_if_absent` returns nil if added a new value or existing if there was one already
target = @targets.put_if_absent(new_target.id, new_target) || new_target
# on first iteration session_id may be null, then if session is present here we must set it to the target
target.session_id = session_id if session_id
@default_target ||= target

new_pending = Concurrent::IVar.new
Expand Down
Loading