Add error report for not found vars/vals

Author: q-ata

compiler/src/dotty/tools/dotc/transform/init/Objects.scala

@@ -336,11 +336,12 @@ object Objects:
     def emptyEnv(meth: Symbol)(using Context): Data =
       new LocalEnv(Map.empty, meth, NoEnv)(valsMap = mutable.Map.empty, varsMap = mutable.Map.empty)
 
-    def valValue(x: Symbol)(using data: Data, ctx: Context): Value =
+    def valValue(x: Symbol)(using data: Data, ctx: Context, trace: Trace): Value =
       data.getVal(x) match
       case Some(theValue) =>
         theValue
       case _ =>
+        report.warning("[Internal error] Value not found " + x.show + "\nenv = " + data.show + ". Calling trace:\n" + Trace.show, Trace.position)
         Bottom
 
     def getVal(x: Symbol)(using data: Data, ctx: Context): Option[Value] = data.getVal(x)
@@ -867,32 +868,28 @@ object Objects:
             Bottom
           end if
         case _ =>
+          report.warning("[Internal error] Variable not found " + sym.show + "\nenv = " + env.show + ". Calling trace:\n" + Trace.show, Trace.position)
           Bottom
       else if sym.isPatternBound then
         // TODO: handle patterns
         Cold
       else
         given Env.Data = env
-        try
-          // Assume forward reference check is doing a good job
-          val value = Env.valValue(sym)
-          if isByNameParam(sym) then
-            value match
-            case fun: Fun =>
-              given Env.Data = fun.env
-              eval(fun.code, fun.thisV, fun.klass)
-            case Cold =>
-              report.warning("Calling cold by-name alias. Call trace: \n" + Trace.show, Trace.position)
-              Bottom
-            case _: RefSet | _: Ref =>
-              report.warning("[Internal error] Unexpected by-name value " + value.show  + ". Calling trace:\n" + Trace.show, Trace.position)
-              Bottom
-          else
-            value
-
-        catch ex =>
-          report.warning("[Internal error] Not found " + sym.show + "\nenv = " + env.show + ". Calling trace:\n" + Trace.show, Trace.position)
-          Bottom
+        // Assume forward reference check is doing a good job
+        val value = Env.valValue(sym)
+        if isByNameParam(sym) then
+          value match
+          case fun: Fun =>
+            given Env.Data = fun.env
+            eval(fun.code, fun.thisV, fun.klass)
+          case Cold =>
+            report.warning("Calling cold by-name alias. Call trace: \n" + Trace.show, Trace.position)
+            Bottom
+          case _: RefSet | _: Ref =>
+            report.warning("[Internal error] Unexpected by-name value " + value.show  + ". Calling trace:\n" + Trace.show, Trace.position)
+            Bottom
+        else
+          value
 
     case _ =>
       if isByNameParam(sym) then
@@ -921,6 +918,7 @@ object Objects:
         else
           Heap.write(addr, value)
       case _ =>
+        report.warning("[Internal error] Variable not found " + sym.show + "\nenv = " + env.show + ". Calling trace:\n" + Trace.show, Trace.position)
 
     case _ =>
       report.warning("Assigning to variables in outer scope. Calling trace:\n" + Trace.show, Trace.position)