Skip to content

Commit 9fd308a

Browse files
committed
chore(streaming): route TemporalStreamingModel logger through make_logger
The model file used raw ``logging.getLogger("agentex.temporal.streaming")``, which returns a logger with no handler attached and no level configured — so the existing ``[TemporalStreamingModel] Initialized ... streaming_mode=...`` INFO log was silently dropped, making it impossible to verify at runtime that a coalesced (or any) streaming mode was actually wired. Switch to the SDK's ``make_logger`` helper (level=INFO, RichHandler in local mode, StreamHandler otherwise) used everywhere else in the SDK. The explicit logger name ``agentex.temporal.streaming`` is preserved so any external logging configuration targeting that name keeps working.
1 parent 35b5f3d commit 9fd308a

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

src/agentex/lib/core/temporal/plugins/openai_agents/models/temporal_streaming_model.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
from __future__ import annotations
33

44
import uuid
5-
import logging
65
from typing import Any, List, Union, Optional, override
76

87
from agents import (
@@ -58,6 +57,7 @@
5857

5958
# AgentEx SDK imports
6059
from agentex.lib import adk
60+
from agentex.lib.utils.logging import make_logger
6161
from agentex.lib.core.tracing.tracer import AsyncTracer
6262
from agentex.types.task_message_delta import TextDelta, ReasoningContentDelta, ReasoningSummaryDelta
6363
from agentex.types.task_message_update import StreamTaskMessageFull, StreamTaskMessageDelta
@@ -69,8 +69,12 @@
6969
streaming_parent_span_id,
7070
)
7171

72-
# Create logger for this module
73-
logger = logging.getLogger("agentex.temporal.streaming")
72+
# Use the SDK's make_logger so this module's INFO/DEBUG output is actually
73+
# visible (raw ``logging.getLogger`` returns a logger with no handler/level
74+
# configured, which silently drops anything below WARNING). Keep the explicit
75+
# name "agentex.temporal.streaming" so any external logging config targeting
76+
# that name keeps working.
77+
logger = make_logger("agentex.temporal.streaming")
7478

7579

7680
def _serialize_item(item: Any) -> dict[str, Any]:

0 commit comments

Comments
 (0)