Improvement/cldsrv 724 legacy related functional tests

[benzekrimaha]

Issue: CLDSRV-724

[codecov]

❌ 18 Tests Failed:

Tests completed	Failed	Passed	Skipped
7581	18	7563	0

View the top 3 failed test(s) by shortest run time

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With default signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "after all" hook for "should list buckets"

Stack Traces | 0s run time

s3.deleteBucket is not a function

"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0s run time

s3.createBucket is not a function

should allow logging when target bucket is owned by same account::PUT bucket logging With default signature with existing bucket should allow logging when target bucket is owned by same account

Stack Traces | 0s run time

s3.putBucketLogging is not a function

should allow logging when target bucket is owned by same account::PUT bucket logging With v4 signature with existing bucket should allow logging when target bucket is owned by same account

Stack Traces | 0s run time

s3.putBucketLogging is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With default signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0.001s run time

s3.config.update is not a function

"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "before all" hook for "should list buckets concurrently"

Stack Traces | 0.001s run time

s3.config.update is not a function

"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.001s run time

s3.createBucket is not a function

should return error if pattern is invalid::Invalid regular expression searches should return error if pattern is invalid

Stack Traces | 0.002s run time

done() called multiple times in test <Invalid regular expression searches should return error if pattern is invalid> of file .../test/mdSearch/basicSearch.js; in addition, done() received error: InvalidArgument: Invalid sql where clause sent as search query
    at throwDefaultError (.../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:288:22)
    at .../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:297:9
    at de_CommandError (.../cloudserver/cloudserver/node_modules/@.../client-s3/dist-cjs/index.js:4868:20)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-serde/dist-cjs/index.js:8:24
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:386:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-retry/dist-cjs/index.js:254:46
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:63:28
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:90:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-logger/dist-cjs/index.js:5:26
    at async makeRequest (.../mdSearch/utils/helpers.js:71:25) {
  '$fault': 'client',
  '$response': [HttpResponse],
  '$retryable': undefined,
  '$metadata': [Object],
  Code: 'InvalidArgument',
  Resource: '',
  RequestId: '27995beccc4483c13bfc'
}

should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With v4 signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1

Stack Traces | 0.002s run time

Expected values to be strictly equal:

undefined !== ''

"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.003s run time

The specified bucket does not exist.

"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"

Stack Traces | 0.003s run time

The specified bucket does not exist.

should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With default signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1

Stack Traces | 0.003s run time

Expected values to be strictly equal:

undefined !== ''

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With v4 signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.017s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

should fail if version id is invalid::PUT object with x-scal-s3-version-id header With default signature error handling validation (without cold storage location) should fail if version id is invalid

Stack Traces | 0.018s run time

Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null

"before each" hook for "should set the rate limit config"::Test put bucket rate limit "before each" hook for "should set the rate limit config"

Stack Traces | 0.484s run time

Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"before each" hook for "should return the rate limit config"::Test get bucket rate limit "before each" hook for "should return the rate limit config"

Stack Traces | 0.529s run time

Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should set the rate limit config"::Test put bucket rate limit "after each" hook for "should set the rate limit config"

Stack Traces | 0.54s run time

Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should return the rate limit config"::Test get bucket rate limit "after each" hook for "should return the rate limit config"

Stack Traces | 0.544s run time

Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"before each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "before each" hook for "should delete the bucket rate limit config"

Stack Traces | 0.652s run time

Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

"after each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "after each" hook for "should delete the bucket rate limit config"

Stack Traces | 0.818s run time

Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[SylvainSenechal]

Suggested change

	// First, get a valid signed URL with maximum allowed expiry
	// First, get a valid signed URL with maximum allowed expiry of 7 days

then remove the other comment, or create a variable named 7daysInSec or something

Also the comment line 60 about the "10 seconds more than limit is weird", because + 604810 means + 7days, not +10 seconds 🤔

[SylvainSenechal]

ah nvm its
604810
not
604800
hard to spot, better to use things like 7 * 24 * 3600 + 10 but whatever, its nit you can leave it